Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 661110 - feature request: app-portage/repoman: detect usage of functions from indirect eclass inheritance
Summary: feature request: app-portage/repoman: detect usage of functions from indirect...
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All All
: Normal enhancement (vote)
Assignee: Portage team
URL: https://bugs.gentoo.org/661108
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-14 01:24 UTC by hanetzer
Modified: 2022-07-12 03:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description hanetzer 2018-07-14 01:24:16 UTC
=net-fs/samba-4.2.14 was using get_version_component_range from versionator,
which it inherited implicitly from linux-info. When linux-info ceased to
inherit versionator (my patch, and partially my fault), it broke.

Ideally, every ebuild which explicitly calls something from an eclass should
inherit that eclass itself, to prevent this sort of issue from arising in the
future.

Reproducible: Always

Steps to Reproduce:
1. edit/create an ebuild, use a function from a second-level inheritance
2. run repoman to check for qa issues
3. commit and push the ebuild
4. change something in the eclass, which could break the ebuild
5. havok
Actual Results:  
repoman doesn't find anything wrong with using functions from eclass b,
which is inherited from eclass a and used in the ebuild.

Expected Results:  
repoman catches the fact that you're using a function from an eclass
which you do not explicitly inherit, and either warns against it or
issues a fatal issue and prevented it from being committed without the
force flag.
Comment 1 hanetzer 2018-07-14 03:00:35 UTC
note, --experimental-inherit y does not check for implicit inheritance
issues.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-04-11 22:42:06 UTC
pkgcheck has IndirectInherit now
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:19 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.