Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 66097 - Gnophone 0.2.4-r1 code is missing break statement
Summary: Gnophone 0.2.4-r1 code is missing break statement
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Net-im project
URL:
Whiteboard:
Keywords:
: 76816 78662 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-10-02 02:06 UTC by kuba tyszko
Modified: 2006-02-04 15:41 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch proposed by kuba tyszko (patch.patch,208 bytes, patch)
2004-10-05 14:12 UTC, Disaster
Details | Diff
patch proposed by lb (gnophone-0.2.4-gcc.3.4.patch,241 bytes, patch)
2004-11-13 00:50 UTC, Luther Blissett
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kuba tyszko 2004-10-02 02:06:37 UTC
When i tries to emerge gnophone 0.2.4-r1 it passes the configure (i have all possible USE flags set) and begins to emake.
then it crashes with error that says "gnophone_gui.c:1399: error: label at end of compound statement", so i created a patch to fix this (patch adds break; where needed), added another epatch line to apply my patch, repeated emerge and it works fine now.

Reproducible: Always
Steps to Reproduce:
1. just try to emerge gnophone 0.2.4-r1
2.
3.

Actual Results:  
the same as sbove

Expected Results:  
make, install and get software to work.

below is patch that i created.


--- src/gnophone_gui.c_org      2004-10-02 10:51:12.000000000 +0200            
                                                          
+++ src/gnophone_gui.c  2004-10-02 10:46:19.000000000 +0200                    
                                                          
@@ -1396,6 +1396,7 @@                                                          
                                                          
                p->moving = 0;                                                 
                                                          
                break;                                                         
                                                          
        default:                                                               
                                                          
+               break;                                                         
                                                          
        }                                                                      
                                                          
        return FALSE;                                                          
                                                          
 }
Comment 1 Disaster 2004-10-05 14:12:42 UTC
Created attachment 41175 [details, diff]
patch proposed by kuba tyszko

I you don't want to become crazy with copy and paste here is the patch ready to
download
Comment 2 Luther Blissett 2004-11-13 00:50:03 UTC
Created attachment 43848 [details, diff]
patch proposed by lb
Comment 3 Patrizio Bassi 2005-08-18 06:10:22 UTC
works for me, easy fix, please apply to portage    
Comment 4 Daniel Black (RETIRED) gentoo-dev 2006-02-04 15:23:08 UTC
*** Bug 76816 has been marked as a duplicate of this bug. ***
Comment 5 Daniel Black (RETIRED) gentoo-dev 2006-02-04 15:23:59 UTC
*** Bug 78662 has been marked as a duplicate of this bug. ***
Comment 6 Daniel Black (RETIRED) gentoo-dev 2006-02-04 15:41:42 UTC
fixed *finally*. Sorry for the delay. Thanks for the patches.