Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 660432 - gentoo/genkernel: remove NFS rsize/wsize options from default
Summary: gentoo/genkernel: remove NFS rsize/wsize options from default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-05 06:56 UTC by Guido Jäkel
Modified: 2019-03-01 05:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Jäkel 2018-07-05 06:56:02 UTC
When using PXE&NFSRoot, the Root-FS is mounted with a very small R/W-Size of 1k. This is a result of the DEFAULT_NFSOPTIONS. At the moment one can't override it by the "nfsroot" Kernel commanline option, because the additional options will be *appended* to the DEFAULT_NFSOPTIONS, but the mount command take the *first* occurence.

Reproducible: Always

Steps to Reproduce:
Apply Kernel command line option nfsroot with additional mount parameter r/wsize.
Actual Results:  
Given mount options for r/wsize by the kernel command line parameter nfsroot will be ignored.

Expected Results:  
Given mount options for r/wsize by the kernel command line parameter nfsroot will be respecded.

I suggest to completely remove "rsize=1024,wsize=1024" from the DEFAULT_NFSOPTIONS:

    The kernel/mount default is "unlimited" and the concrete values will be with negotiated with the NFS server.
    If optional values for {r,w}size are passed to the kernel commandline parameter "nfrsoot=...,", this additinal options are appended to the resulting mount options. But (at least) for {r,w}size, the first occurrence strikes; i.e. the values passed via the commandline are ignored in fact.

As a more complex alternative, the function "findnfsmount()" (@ initrd.scripts, 569ff.) may be rewritten to parse and kick out double-occurences of options.

Background: I run into this issue booting a diskless server; using PXE for the kernel and initramfs and NFS for the rootfs.

I suggested a patch as https://github.com/gentoo/genkernel/pull/4
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2019-03-01 05:56:00 UTC
Merged via https://github.com/gentoo/genkernel/pull/4