Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659872 - dev-libs/libuv-1.21.0 ABI changed without SONAME bump
Summary: dev-libs/libuv-1.21.0 ABI changed without SONAME bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-02 17:30 UTC by Joel
Modified: 2018-07-06 11:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joel 2018-07-02 17:30:13 UTC
Hi,

last day I upgraded libuv to version 1.21.0. I have also installed nodejs 8.11.3 and 1.8.0 (up to date ~amd64) system. 

However, a crash happened when using yarn to compile vscode. The crash was solved when I recompiled nodejs. I don't know enough about nodejs, yarn and libuv (I just use it to compile vscode), but from that experience I think that we should force nodejs recompilation when libuv gets upgraded.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2018-07-06 11:39:04 UTC
These are suspect:

--- libuv-1.20.3/image/usr/include/uv.h 2018-07-06 13:33:14.946535197 +0200
+++ libuv-1.21.0/image/usr/include/uv.h 2018-07-06 13:34:31.667310153 +0200
@@ -997,16 +1004,18 @@ UV_EXTERN int uv_queue_work(uv_loop_t* l
 UV_EXTERN int uv_cancel(uv_req_t* req);


-struct uv_cpu_info_s {
-  char* model;
-  int speed;
-  struct uv_cpu_times_s {
+struct uv_cpu_times_s {
     uint64_t user;
     uint64_t nice;
     uint64_t sys;
     uint64_t idle;
     uint64_t irq;
-  } cpu_times;
+};
+
+struct uv_cpu_info_s {
+  char* model;
+  int speed;
+  struct uv_cpu_times_s cpu_times;
 };

 struct uv_interface_address_s {
@@ -1132,6 +1141,7 @@ typedef enum {
   UV_FS_READLINK,
   UV_FS_CHOWN,
   UV_FS_FCHOWN,
+  UV_FS_LCHOWN,
   UV_FS_REALPATH,
   UV_FS_COPYFILE
 } uv_fs_type;
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2018-07-06 11:59:06 UTC
Fixed in -r1.