Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659534 - net-misc/ntpsec-1.1.1 - needs ipv6 support in test phase
Summary: net-misc/ntpsec-1.1.1 - needs ipv6 support in test phase
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Steve Arnold
URL:
Whiteboard:
Keywords:
Depends on: 665188
Blocks:
  Show dependency tree
 
Reported: 2018-06-28 19:49 UTC by Marcin Mirosław
Modified: 2018-09-05 15:05 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (file_659534.txt,5.11 KB, text/plain)
2018-06-28 19:49 UTC, Marcin Mirosław
Details
potential patch for ./wscript (scrap.patch,821 bytes, patch)
2018-07-17 19:56 UTC, James Browning
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Mirosław 2018-06-28 19:49:26 UTC
Created attachment 537650 [details]
emerge --info

[180/182] Processing build/main/tests/pylib/test_agentx.py
20:39:23 runner ['/usr/bin/python2.7', 'test_agentx.py']
[181/182] Processing build/main/tests/pylib/test_agentx_packet.py
20:39:24 runner ['/usr/bin/python2.7', 'test_agentx_packet.py']
[182/182] Processing build/main/tests/pylib/test_packet.py
20:39:24 runner ['/usr/bin/python2.7', 'test_packet.py']
Waf: Leaving directory `/var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7/build/main'
Wrote test log to:  /var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7/build/main/test.log
execution summary
  tests that pass 6/7
    /var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7/build/main/tests/test_libntp
    /var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7/build/main/tests/test_ntpd
    /var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7/build/main/tests/pylib/test_statfiles.py
    /var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7/build/main/tests/pylib/test_util.py
    /var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7/build/main/tests/pylib/test_agentx.py
    /var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7/build/main/tests/pylib/test_agentx_packet.py
  tests that fail 1/7
    /var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7/build/main/tests/pylib/test_packet.py
stderr:
....................................E.....................
======================================================================
ERROR: test_MRUEntry (__main__.TestMisc)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_packet.py", line 563, in test_MRUEntry
    self.assertEqual(cls.sortaddr(),
  File "/var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7/build/main/tests/pylib/ntp/packet.py", line 725, in sortaddr
    return socket.inet_pton(socket.AF_INET6, addr)
error: can't use AF_INET6, IPv6 is disabled

----------------------------------------------------------------------
Ran 58 tests in 0.035s

FAILED (errors=1)

 * ERROR: net-misc/ntpsec-1.1.1::gentoo failed (compile phase):
 *   build failed
 *
 * Call stack:
 *     ebuild.sh, line  124:  Called src_compile
 *   environment, line 3893:  Called python_foreach_impl 'run_in_build_dir' 'python_compile'
 *   environment, line 3361:  Called multibuild_foreach_variant '_python_multibuild_wrapper' 'run_in_build_dir' 'python_compile'
 *   environment, line 2509:  Called _multibuild_run '_python_multibuild_wrapper' 'run_in_build_dir' 'python_compile'
 *   environment, line 2507:  Called _python_multibuild_wrapper 'run_in_build_dir' 'python_compile'
 *   environment, line  522:  Called run_in_build_dir 'python_compile'
 *   environment, line 3875:  Called python_compile
 *   environment, line 3891:  Called waf-utils_src_compile
 *   environment, line 4918:  Called die
 * The specific snippet of code:
 *       "${WAF_BINARY}" ${_mywafconfig} ${jobs} || die "build failed"
 *
 * If you need support, post the output of `emerge --info '=net-misc/ntpsec-1.1.1::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=net-misc/ntpsec-1.1.1::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/net-misc/ntpsec-1.1.1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/net-misc/ntpsec-1.1.1/temp/environment'.
 * Working directory: '/var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1-python2_7'
 * S: '/var/tmp/portage/net-misc/ntpsec-1.1.1/work/ntpsec-1.1.1'
Comment 1 Marcin Mirosław 2018-06-28 19:50:23 UTC
Why test phase appears without USE=test ?
Comment 2 James Browning 2018-07-17 19:56:42 UTC
Created attachment 539912 [details, diff]
potential patch for ./wscript

Seems to stop tests from building/executing when running './waf build'.
Does not seem to stop them when running './waf check'.
The resulting products were not tested.
Comment 3 Matt Selsky 2018-07-28 23:09:19 UTC
Use "./waf build --notests" to disable running tests as part of the build.  No code changes are necessary.

FYI "./waf check" will force running all tests since it's intended for running tests. If you don't want to run tests, then don't run it.
Comment 4 Matt Selsky 2018-07-28 23:25:12 UTC
I'll look at how we can conditionalize this test on python actually supporting IPv6, in the upstream code.
Comment 5 Matt Selsky 2018-07-29 03:18:31 UTC
Should be fixed upstream in https://gitlab.com/NTPsec/ntpsec/merge_requests/733
Comment 6 James Browning 2018-08-04 22:06:43 UTC
addressed upstream in https://gitlab.com/NTPsec/ntpsec/merge_requests/733
will be fixed in the next release.
Comment 7 Anthony Basile gentoo-dev 2018-08-04 23:34:45 UTC
(In reply to James Browning from comment #6)
> addressed upstream in https://gitlab.com/NTPsec/ntpsec/merge_requests/733
> will be fixed in the next release.

since this is just a problem in tests, we can live with it until the next release.
Comment 8 Marcin Mirosław 2018-08-05 14:15:10 UTC
(In reply to Anthony Basile from comment #7)
> (In reply to James Browning from comment #6)
> > addressed upstream in https://gitlab.com/NTPsec/ntpsec/merge_requests/733
> > will be fixed in the next release.
> 
> since this is just a problem in tests, we can live with it until the next
> release.

But test phase is run unconditionally, see comment #1
Comment 9 James Browning 2018-08-17 13:58:36 UTC
https://lists.ntpsec.org/pipermail/devel/2018-August/006461.html suggest that a new release could be out as soon as the 27th.
Comment 10 James Browning 2018-08-29 13:02:07 UTC
There is a new release out 1.1.2 does not address running tests always. It does make ipv6 tests run only when ipv6 enabled.
Comment 11 Marcin Mirosław 2018-09-05 09:38:33 UTC
ntpsec-1.1.2 installed without this problem. Thank you for your effort.