Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 65932 - catalyst incorrectly spaceing use variables in make.conf
Summary: catalyst incorrectly spaceing use variables in make.conf
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Release Media
Classification: Unclassified
Component: Everything (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo LiveCD Package Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-30 09:17 UTC by REdOG
Modified: 2005-03-25 11:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to check if settings are of type list or string before appending or extending (generic_stage_target.py_patch,2.20 KB, patch)
2004-09-30 12:05 UTC, REdOG
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description REdOG 2004-09-30 09:17:10 UTC
useing -C and livecd/use="-X -gtk -gnome -svga -alsa -doc -arts -java -kde -qt -ipv6 socks5 livecd fbcon ssl" durring livecd-stage1 catalyst changes make.conf from the seed stage from:

# These settings were set by the catalyst build script that automatically built this stage
# Please consult /etc/make.conf.example for a more detailed example
CFLAGS="-Os -pipe"
CHOST="i386-pc-linux-uclibc"
CXXFLAGS="-Os -pipe"

to:

# These settings were set by the catalyst build script that automatically built this stage
# Please consult /etc/make.conf.example for a more detailed example
CFLAGS="-Os -pipe"
CHOST="i386-pc-linux-uclibc"
USE="- X   - g t k   - g n o m e   - s v g a   - a l s a   - d o c   - a r t s   - j a v a   - k d e   - q t   - i p v 6   s o c k s 5   l i v e c d   f b c o n   s s l"
CXXFLAGS="-Os -pipe"



Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
Causes incorrect use flags to be used when building stage1

Expected Results:  
should correctly parse the flags into make.conf
Comment 1 REdOG 2004-09-30 12:05:34 UTC
Created attachment 40797 [details, diff]
Patch to check if settings are of type list or string before appending or extending

I'm Not certian if this is the best place to do this sort of checking but it
works for me
Comment 2 REdOG 2004-09-30 14:24:56 UTC
err nm that patch it screws up more...

I was trying to pass the use flags in a variable inside a bash script

livecd_use="-X -gtk -gnome -svga -alsa -doc -arts -java -kde -qt -ipv6 socks5 livecd fbcon ssl"

then run catalyst -C livecd/use="${livecd_use}" ... in a script

livecd_use should instead be set like this to avoid it being converted into a string(a list is expected) once python gets it:

livecd_use="'-X' '-gtk' '-gnome' '-svga' '-alsa' '-doc' '-arts' '-java' '-kde' '
-qt' '-ipv6' 'socks5' 'livecd' 'fbcon' 'ssl'"
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2005-03-25 11:24:08 UTC
Moving these so we can remove the "Install CD" component from "Gentoo Linux".

I apologize to everyone for this spam, but according to the bugzilla developers,
this is the only reasonable way to do this.