Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 658544 - sys-kernel/gentoo-sources-4.17.x regression: kvm_ptp broken for Linux x86_32 guests
Summary: sys-kernel/gentoo-sources-4.17.x regression: kvm_ptp broken for Linux x86_32 ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard: gentoo-sources 4.17-5
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2018-06-19 22:46 UTC by Andreas Steinmetz
Modified: 2018-07-05 14:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Local fix for ptp_kvm failure (kvmclock.patch,357 bytes, patch)
2018-06-19 22:46 UTC, Andreas Steinmetz 		Details | Diff
Upstream updated patch (1700_define-pvclock-pvti-cpu0-va-setter-for-X86-32.patch,1.76 KB, patch)
2018-06-21 22:42 UTC, Mike Pagano 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Steinmetz 2018-06-19 22:46:52 UTC 
Created attachment 536472 [details, diff]
Local fix for ptp_kvm failure

Well, I tried to send this to kvm@vger.kernel.org but it seems to be delivered to /dev/null if you're not subscribed...

setup_vsyscall_timeinfo() is only defined for x86_64, thus pvclock_set_pvti_cpu0_va() gets not called and as the result initialization of ptp_kvm fails.

Thus 32 bit guest userspace has no /dev/ptp0 device.

The attached patch at least works for me.

The regression occured somewhere between 4.14.13 and 4.17.2 (sorry, I don't have more details).
Comment 1 Mike Pagano gentoo-dev 2018-06-19 23:39:19 UTC 
Do you want to subscribe and submit this upstream, or do you want us to do it on your behalf?
Comment 2 Andreas Steinmetz 2018-06-20 06:04:32 UTC 
It would be very kind of you if you could notify upstream.
Comment 3 Mike Pagano gentoo-dev 2018-06-21 22:42:02 UTC 
Created attachment 536750 [details, diff]
Upstream updated patch

Andreas,  can you test this patch from upstream concerning your issue and tell me if it fixes it?
Comment 4 Mike Pagano gentoo-dev 2018-06-25 12:40:38 UTC 
I took out your patch from gentoo-sources, let me know if the upstream patch works, be nice to get it in with 4.17.3.
Comment 5 Andreas Steinmetz 2018-06-25 15:58:04 UTC 
Confirmed, upstream patch works.
Comment 6 Mike Pagano gentoo-dev 2018-06-29 23:19:44 UTC 
Tee'ed up for next gentoo-sources release
Comment 7 Mike Pagano gentoo-dev 2018-07-05 14:03:05 UTC 
Included in gentoo-sources-4.17.4