Bug 65791 – net-im/centericq-4.11.0 doesn't compile with gcc3.4

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description Christian Rubbert 2004-09-29 03:55:29 UTC]

Error:

In file included from ../libicq2000/Contact.h:29,
                 from ../libicq2000/ContactList.h:28,
                 from ContactList.cpp:22:
../libicq2000/sigslot.h: In constructor `sigslot::_connection0<dest_type, mt_policy>::_connection0()':
../libicq2000/sigslot.h:748: error: `pobject' undeclared (first use this function)
../libicq2000/sigslot.h:748: error: (Each undeclared identifier is reported only once for each function it appears in.)
../libicq2000/sigslot.h:749: error: `pmemfun' undeclared (first use this function)
../libicq2000/sigslot.h: In constructor `sigslot::_connection1<dest_type, arg1_type, mt_policy>::_connection1()':
../libicq2000/sigslot.h:789: error: `pobject' undeclared (first use this function)
../libicq2000/sigslot.h:790: error: `pmemfun' undeclared (first use this function)
../libicq2000/sigslot.h: In constructor `sigslot::_connection2<dest_type, arg1_type, arg2_type, mt_policy>::_connection2()':
../libicq2000/sigslot.h:830: error: `pobject' undeclared (first use this function)
../libicq2000/sigslot.h:831: error: `pmemfun' undeclared (first use this function)
../libicq2000/sigslot.h: In member function `void sigslot::signal0<mt_policy>::connect(dest_type*, void (dest_type::*)())':
../libicq2000/sigslot.h:892: error: `m_connected_slots' undeclared (first use this function)
../libicq2000/sigslot.h: In member function `void sigslot::signal0<mt_policy>::connect(sigslot::signal0<mt_policy>&)':
../libicq2000/sigslot.h:900: error: `m_connected_slots' undeclared (first use this function)
../libicq2000/sigslot.h: In member function `void sigslot::signal0<mt_policy>::emit()':

etc etc etc

I've adapted the patch for centericq 4.9.12 to apply cleanly to 4.11.0 and fixed some new compile bugs. Patch attached.

[Comment 1 Christian Rubbert 2004-09-29 03:56:16 UTC]

Created attachment 40697 [details, diff]
Patch to compile centericq 4.11.0 with gcc 3.4

[Comment 2 Kelly Harnden (uglyman) 2004-10-13 07:40:41 UTC]

Hi.
Just wanted to say... I had the same issue. Couldn't compile with the latest gcc. So let me add my official me too. I tested your patch it worked perfectly. I just moved the 4.9.12 ebuild to my portage overlay.. changed the version to 4.11 and changed the epatch line to use your patch. then I commented out the lines that disable aim etc... and boom. worked perfect.

and one more item of business: THANK YOU THANK YOU THANK YOU I have been having trouble with this for a long time. and I am finally able to get back on yahoo which has been broken for me for months. THANKS!!!!!

[Comment 3 bugs 2004-10-13 21:52:18 UTC]

FYI, version 4.12.0 has been released.
Copied 4.11.0 to 4.12.0 and added an epatch.
Didn't know about this bug so used:
http://mailman.linuxpl.org/pipermail/cicq/2004-August/001472.html

But looks like what is attached here is Michael Jennings' patch anyway.
Seems to compile fine.

[Comment 4 Don Seiler (RETIRED) 2004-10-18 13:30:18 UTC]

*** Bug 68041 has been marked as a duplicate of this bug. ***

[Comment 5 Ingo -LaSombra- Hoffmann 2004-10-18 15:51:58 UTC]

Created attachment 42129 [details, diff]
centericq-4.12.0-r1 to compile with gcc 3.4

[Comment 6 Ingo -LaSombra- Hoffmann 2004-10-18 15:53:34 UTC]

Created attachment 42130 [details, diff]
centericq-4.12.0-gcc34.patch the patch for the above ebuild

[Comment 7 Ingo -LaSombra- Hoffmann 2004-10-18 15:55:27 UTC]

The patch is working fine with 4.12.0 for now.
Hope it works for everybody :)

[Comment 8 Tassilo Horn 2004-10-19 05:40:55 UTC]

It works for me. 

Thanks Ingo.

[Comment 9 Alexander Ivanchev 2004-10-23 06:44:01 UTC]

Hopefully in portage any time soon

[Comment 10 Andrew Kirilenko 2004-10-24 13:50:12 UTC]

And can you please add all the `irc`, `gg` etc flags?

[Comment 11 Michael Schwendt 2004-11-13 07:15:46 UTC]

Just for reference, while making an older version of centericq build with gcc 3.4, I used a different and cleaner approach at patching it:

  https://bugzilla.fedora.us/attachment.cgi?id=925&action=view

For instance, instead of changing the type of enumeration type variables to integer, I defined a proper post-increment operator for the enumeration types. With that, I could fix all the for-loops which failed to compile with gcc 3.4, and I didn't have to cast from integer back to enumeration types in many other places.

[Comment 12 FieldySnuts 2004-12-17 11:12:26 UTC]

Is the fix going into portage any time? 4.12.0 does not and has not compiled for me  yet.

[Comment 13 Wolfram Schlich (RETIRED) 2004-12-17 14:01:42 UTC]

I will have konst (the cicq developer) comment on that.
I'd also like to have him provide a patch.

[Comment 14 Wolfram Schlich (RETIRED) 2004-12-17 14:50:29 UTC]

quoting konst: the 3.4 issues, they are already fixed in cvs and during this weekend there will be a new version of centericq

I will add the ebuild as soon as 4.13.0 is released.

[Comment 15 Daniel Webert 2004-12-20 05:49:08 UTC]

4.13.0 is released ...

[Comment 16 Wolfram Schlich (RETIRED) 2004-12-20 06:22:29 UTC]

just committed net-im/centericq-4.13.0. give it some time to make its way to the mirrors.