Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 657028 - app-text/journal-9999 ebuild cleanup
Summary: app-text/journal-9999 ebuild cleanup
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alon Bar-Lev (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-06-01 07:19 UTC by Alon Bar-Lev (RETIRED)
Modified: 2019-11-29 09:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-app-text-xournal-ebuild-cleanups.patch (0001-app-text-xournal-ebuild-cleanups.patch,3.33 KB, patch)
2018-06-01 07:19 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
app-text-xournal-ebuild-cleanups.patch (0001-app-text-xournal-ebuild-cleanups.patch,1.58 KB, patch)
2018-06-01 20:52 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
app-text-xournal-ebuild-cleanups.patch (0001-app-text-xournal-ebuild-cleanups.patch,1.54 KB, patch)
2018-06-02 18:45 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
app-text-xournal-ebuild-cleanups.patch (0001-app-text-xournal-ebuild-cleanups.patch,1.13 KB, patch)
2018-06-03 07:43 UTC, Alon Bar-Lev (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-01 07:19:01 UTC
Created attachment 534368 [details, diff]
0001-app-text-xournal-ebuild-cleanups.patch

1. use eapi 6 PATCHES instead of manual invocation.

2. use eapi 6 DOCS, default are sufficient as package installs the rest.

3. "default_src_prepare" should have been "default", but it skips the gnome
   default, so 9999 package skips autoreconf.  it should have been
   gnome2_src_prepare to make it work, not required now because we removed the
   src_prepare()

4. use single emake install.

5. remove the html-doc installation as package installs its docs, we had
   duplicate docs one of us and one of package.

6. patch package to install docs in htmldir instead of pkgdatadir, sent to
   upstream.

---

if you ack I can push
Comment 1 Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-01 20:52:26 UTC
Created attachment 534434 [details, diff]
app-text-xournal-ebuild-cleanups.patch

This time upstream was fast and applied the doc patch.
Comment 2 Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-02 18:45:44 UTC
Created attachment 534582 [details, diff]
app-text-xournal-ebuild-cleanups.patch
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2018-06-03 07:43:26 UTC
Created attachment 534610 [details, diff]
app-text-xournal-ebuild-cleanups.patch

Upstream resolved the aspect ratio issue
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-11-29 09:23:47 UTC
ENOSUCHPACKAGE