Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 656218 - app-admin/puppet-lint-2.3.5: puppet-lint.rb:119:in `%': key{linenumber} not found (KeyError)
Summary: app-admin/puppet-lint-2.3.5: puppet-lint.rb:119:in `%': key{linenumber} not f...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sysadmin Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-21 07:52 UTC by Michał Górny
Modified: 2018-05-21 10:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-05-21 07:52:16 UTC 
I'm trying to lint our puppet repo, and I get, for practically every file:

(LINT.PP) manifests/site.pp
/usr/lib64/ruby/gems/2.3.0/gems/puppet-lint-2.3.5/lib/puppet-lint.rb:119:in `%': key{linenumber} not found (KeyError)
	from /usr/lib64/ruby/gems/2.3.0/gems/puppet-lint-2.3.5/lib/puppet-lint.rb:119:in `format_message'
	from /usr/lib64/ruby/gems/2.3.0/gems/puppet-lint-2.3.5/lib/puppet-lint.rb:166:in `block in report'
	from /usr/lib64/ruby/gems/2.3.0/gems/puppet-lint-2.3.5/lib/puppet-lint.rb:156:in `each'
	from /usr/lib64/ruby/gems/2.3.0/gems/puppet-lint-2.3.5/lib/puppet-lint.rb:156:in `report'
	from /usr/lib64/ruby/gems/2.3.0/gems/puppet-lint-2.3.5/lib/puppet-lint.rb:215:in `print_problems'
	from /usr/lib64/ruby/gems/2.3.0/gems/puppet-lint-2.3.5/lib/puppet-lint/bin.rb:67:in `block in run'
	from /usr/lib64/ruby/gems/2.3.0/gems/puppet-lint-2.3.5/lib/puppet-lint/bin.rb:62:in `each'
	from /usr/lib64/ruby/gems/2.3.0/gems/puppet-lint-2.3.5/lib/puppet-lint/bin.rb:62:in `run'
	from /usr/lib64/ruby/gems/2.3.0/gems/puppet-lint-2.3.5/bin/puppet-lint:7:in `<top (required)>'
	from /usr/bin/puppet-lint:9:in `load'
	from /usr/bin/puppet-lint:9:in `<main>'
Comment 1 Hans de Graaff gentoo-dev Security 2018-05-21 08:06:25 UTC 
It seems to work fine for me. Could you include an innocent failing file from the repo?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-05-21 10:23:14 UTC 
To be honest, I was hoping Robin would try to reproduce it first.  But I've already found the problem.  We're wrongly checking for puppet version, and passing old format string to it.