655602 – dev-libs/nss-3.37 on ARM - Hacl_Poly1305_32.c:(.text.Hacl_Poly1305_32_init+0x80): undefined reference to `FStar_UInt128_uint64_to_uint128'

Bug 655602 - dev-libs/nss-3.37 on ARM - Hacl_Poly1305_32.c:(.text.Hacl_Poly1305_32_init+0x80): undefined reference to `FStar_UInt128_uint64_to_uint128'

Summary: dev-libs/nss-3.37 on ARM - Hacl_Poly1305_32.c:(.text.Hacl_Poly1305_32_init+0x...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	ARM Linux

Importance:	Normal normal (vote)
Assignee:	Mozilla Gentoo Team

URL:	https://bugzilla.mozilla.org/show_bug...
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2018-05-12 18:19 UTC by tt_1
Modified:	2018-05-23 20:15 UTC (History)
CC List:	0 users

See Also:	655636
Package list:
Runtime testing required:	---

Attachments
nss-3.37-build.log.gz (nss-3.37-build.log.gz,8.21 KB, application/gzip) 2018-05-12 18:19 UTC, tt_1	Details
output of emerge --info (emerge--info,4.83 KB, text/plain) 2018-05-12 18:20 UTC, tt_1	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description tt_1 2018-05-12 18:19:15 UTC

Created attachment 531100 [details]
nss-3.37-build.log.gz

So, it looks as if there is a breakage in nss-3.37, which compiles fine on amd64, also 3.36.1 is not affected by this. Tested gcc-6.4.0 and gcc-7.3.0 toolchain, with both the same build failure. 

I checked a few other sources of informations, but could not find any other bug reports or patches.

Comment 1 tt_1 2018-05-12 18:20:07 UTC

Created attachment 531102 [details]
output of emerge --info

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2018-05-13 08:08:40 UTC


*** This bug has been marked as a duplicate of bug 646382 ***

Comment 3 tt_1 2018-05-15 05:14:07 UTC

Are you sure that this is a duplicate? It might have the same reason, but code base and the error itself changed quite a bit from 3.36 to 3.37 in my opinion.

Comment 4 tt_1 2018-05-17 11:39:05 UTC

bug on mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1459739

fix: https://hg.mozilla.org/projects/nss-try/rev/259444458a1a7f2ce1813ebe88d924173d5daf0c

happens on arm as well

Comment 5 tt_1 2018-05-17 11:43:09 UTC

Fstar.c must be inherited into the makefile, and that's it. 

https://bugs.gentoo.org/655636 is a duplicate of this to be honest, https://bugs.gentoo.org/show_bug.cgi?id=646382 is something different.

Comment 6 tt_1 2018-05-23 17:20:50 UTC

pullrequest: https://github.com/gentoo/gentoo/pull/8533

Comment 7 Larry the Git Cow gentoo-dev

2018-05-23 20:06:42 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=16e4471e4327d02cd19dd5001f5a76e71fec3686

commit 16e4471e4327d02cd19dd5001f5a76e71fec3686
Author:     stefson <herrtimson@yahoo.de>
AuthorDate: 2018-05-23 17:13:05 +0000
Commit:     Ian Stakenvicius <axs@gentoo.org>
CommitDate: 2018-05-23 20:06:33 +0000

    dev-lang/nss: fix compile on arm and hppa
    
    Upstream has not accepted this patch yet, but it is reported to fix the same
    issue on other platforms and is otherwise benign.
    
    Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1459739
    Bug: http://bugs.gentoo.org/655602
    Bug: http://bugs.gentoo.org/655636
    Closes: https://github.com/gentoo/gentoo/pull/8533

 .../files/nss-3.37-fix-fstar-missing-symbols.patch | 34 ++++++++++++++++++++++
 dev-libs/nss/nss-3.37.ebuild                       |  1 +
 2 files changed, 35 insertions(+)

Comment 8 tt_1 2018-05-23 20:15:44 UTC

Thanks for the merge! The patch is in the nss-try branch, so if it doesn't blow up something else it should be included in the next release. Therefore, closing.