Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 655304 - [gnome overlay] app-crypt/seahorse-9999 is using meson now
Summary: [gnome overlay] app-crypt/seahorse-9999 is using meson now
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-09 02:09 UTC by cyrillic
Modified: 2022-10-10 22:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
seahorse-9999.ebuild (seahorse-9999.ebuild,1.83 KB, text/plain)
2018-05-09 02:12 UTC, cyrillic
Details
seahorse-9999.ebuild (seahorse-9999.ebuild,1.50 KB, text/plain)
2018-05-31 02:00 UTC, cyrillic
Details
meson.eclass.patch (meson.eclass.patch,550 bytes, patch)
2018-05-31 02:05 UTC, cyrillic
Details | Diff
seahorse-9999.ebuild (seahorse-9999.ebuild,1.58 KB, text/plain)
2018-05-31 18:36 UTC, cyrillic
Details
seahorse-9999.ebuild (seahorse-9999.ebuild,1.56 KB, text/plain)
2018-05-31 21:48 UTC, cyrillic
Details
build.log (build.log,211.47 KB, text/plain)
2018-05-31 22:05 UTC, cyrillic
Details
seahorse-9999.ebuild (seahorse-9999.ebuild,1.57 KB, text/plain)
2018-06-02 23:52 UTC, cyrillic
Details
ifdef_consistency.patch (ifdef_consistency.patch,784 bytes, patch)
2018-06-25 01:04 UTC, cyrillic
Details | Diff
seahorse-9999.ebuild (seahorse-9999.ebuild,1.65 KB, text/plain)
2018-06-25 01:07 UTC, cyrillic
Details
seahorse-9999.ebuild (seahorse-9999.ebuild,1.64 KB, text/plain)
2018-11-16 16:12 UTC, cyrillic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description cyrillic 2018-05-09 02:09:13 UTC
[gnome overlay] app-crypt/seahorse-9999 is using meson now

Reproducible: Always




>>> Source unpacked in /tmp/portage/app-crypt/seahorse-9999/work
>>> Preparing source in /tmp/portage/app-crypt/seahorse-9999/work/seahorse-9999 ...
sed: can't read configure.ac: No such file or directory
Comment 1 cyrillic 2018-05-09 02:12:05 UTC
Created attachment 530554 [details]
seahorse-9999.ebuild

Converted to meson, this one works better.
Comment 2 Sobhan Mohammadpour (RETIRED) gentoo-dev 2018-05-30 08:21:49 UTC
(In reply to cyrillic from comment #1)
> Created attachment 530554 [details]
> seahorse-9999.ebuild
> 
> Converted to meson, this one works better.

the sed in src_prepare is unnecessary.

other than that

using meson_use and gnome_meson elcass isn't a bad idea.

i don't see anything else wrong with it. please fix the src_prepare so
i can push this :D
Comment 3 cyrillic 2018-05-31 02:00:19 UTC
Created attachment 534208 [details]
seahorse-9999.ebuild

In cleaning up this ebuild, I
- made src_configure more closely resemble upstream
- noticed that vala and ssh are no longer optional
- made better use of existing eclasses
Comment 4 cyrillic 2018-05-31 02:05:53 UTC
Created attachment 534210 [details, diff]
meson.eclass.patch

I also moved USE="debug" out of the ebuild and into the eclass where it makes more sense.
... after that, I noticed that seahorse cannot build with USE="-debug", because there is something wrong with ldap.  It would be nice if someone who actually knows what they are doing could look this over :)
Comment 5 cyrillic 2018-05-31 18:36:49 UTC
Created attachment 534316 [details]
seahorse-9999.ebuild

Icon cache needed updating too.
Comment 6 cyrillic 2018-05-31 21:48:42 UTC
Created attachment 534362 [details]
seahorse-9999.ebuild

gnome2-live.eclass is overrated, switching to git-r3.eclass
Comment 7 cyrillic 2018-05-31 22:05:15 UTC
Created attachment 534364 [details]
build.log

This is what happens when USE="-debug"
I think some of the required headers are not getting included.

With USE="debug" everything seems to build and install fine.
Comment 8 cyrillic 2018-06-02 23:52:31 UTC
Created attachment 534600 [details]
seahorse-9999.ebuild

Ok, now I understand why debug would not work from inside the ebuild.
It is because gnome-meson_src_configure was passing an empty emesonargs to meson_src_configure, so none of the options were having any effect.

So now, seahorse builds with USE="-debug -ldap", and no eclass modifications are needed.

There is still something broken with USE="ldap", but this could be filed as a separate bug once the ebuild is pushed.
Comment 9 cyrillic 2018-06-06 22:06:59 UTC
(In reply to cyrillic from comment #4)
> It would be nice if someone who
> actually knows what they are doing could look this over :)

When I re-read this, it sounded a bit insulting, but it was not directed at anyone. I was only admitting that I do not know what I am doing.
Comment 10 cyrillic 2018-06-25 01:04:42 UTC
Created attachment 537140 [details, diff]
ifdef_consistency.patch

The USE="ldap" mystery is solved.  Apparently #if and #ifdef do not do the same thing.  Using the right one was key to compiling LDAP support without having to enable the debugging code.
Comment 11 cyrillic 2018-06-25 01:07:29 UTC
Created attachment 537142 [details]
seahorse-9999.ebuild

This one should be ready to push now that all useflag combinations are working.
Comment 12 Peter Große 2018-11-07 16:55:54 UTC
I used your ebuild to build the latest tagged version 3.30.0.

I only had to make small modifications: the dependencies app-crypt/gcr and app-crypt/libsecret need the USE flag "vala" enabled.

With that, it compiles and starts, but is still a buggy mess. :/
Comment 13 cyrillic 2018-11-16 16:12:39 UTC
Created attachment 555332 [details]
seahorse-9999.ebuild

Removed gnome-meson eclass because other Gnome overlay packages seem to be headed in this direction too.
Comment 14 Matt Turner gentoo-dev 2022-10-10 22:38:30 UTC
Cleaned out the gnome-overlay a while ago.