Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 65394 - Hack restriction patch for xscreensaver
Summary: Hack restriction patch for xscreensaver
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Jonathan Smith (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-26 05:26 UTC by Fredrik Tolf
Modified: 2005-06-25 11:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Hack restriction patch (restrict.patch,1.81 KB, patch)
2004-09-26 05:27 UTC, Fredrik Tolf
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fredrik Tolf 2004-09-26 05:26:29 UTC
I'd like to suggest the attached patch for inclusion into the xscreensaver ebuild.

It allows one to specify a "screensBlankOnly" property in ones ~/.xscreensaver file, which specifies, on a multi-screen display, screens that should not have a screensaver hack started on them, but rather only be blanked.

The rationale is that if one has a multiscreen display where, for example, one display on connected to your TV, it's unnecessary to waste CPU time on running a screensaver on the TV which probably isn't on anyway. Thus, this patch allows the TV to just be blanked instead of having a screensaver hack running on it.

I've suggested it upstream to JWZ, but I have not received a reply at all.
Comment 1 Fredrik Tolf 2004-09-26 05:27:13 UTC
Created attachment 40439 [details, diff]
Hack restriction patch
Comment 2 Don Seiler (RETIRED) gentoo-dev 2005-02-24 13:39:54 UTC
Does this not happen in 4.16 or 4.20.  I see this note in the README:

Changes since 4.12:   * On Xinerama systems, xscreensaver now runs one hack on
                        each monitor (just like in "real" multi-head mode)
                        instead of running one hack stretching across all the
                        screens.  Note that for this to work with any 3rd party
                        screensavers, they must update their "vroot.h" file.
Comment 3 Fredrik Tolf 2005-02-25 10:58:37 UTC
That's a completely different (and orthogonal) thing. What that means is that, previously (before 4.12), xscreensaver would run exactly one hack that was stretched over all screens of a display. In 4.12 and later, it will run one hack per screen. Also, that only affects xscreensaver if you use Xinerama. In other words, it makes Xinerama displays behave as non-Xinerama displays.

What this patch does is it prevents hacks from being run on the screens that you specify, and instead only blanks them. Regardlessly of whether one uses Xinerama.
Comment 4 Jonathan Smith (RETIRED) gentoo-dev 2005-06-25 11:09:24 UTC
gentoo does not provide features for programs which upstream does not wish to
include unless there is a security problem

also, look for the "blank after" feature