Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 65350 - conceal patch for vim
Summary: conceal patch for vim
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement
Assignee: Vim Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-25 14:06 UTC by Moshe Kamensky
Modified: 2004-10-01 16:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for vim.eclass to (optionally) enable the conceal patch (vim.eclass.patch,681 bytes, patch)
2004-09-25 14:08 UTC, Moshe Kamensky
Details | Diff
the conceal patch for vim (vim-conceal-ownsyntax.patch.gz,40.56 KB, patch)
2004-09-25 14:10 UTC, Moshe Kamensky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Moshe Kamensky 2004-09-25 14:06:26 UTC
Vince Negri's conceal patch allows certain parts of the text to be hidden. Some text (defined using the syntax highlighting mechanism) will not be displayed at all, unless the cursor is on that line. This is useful for hiding markup, such as terminal control sequences, latex commands, etc.

The attached patch to vim.eclass allows the user to enable this patch when installing vim, via a 'conceal' use flag.

To install vim with the conceal patch:
1. go to ${PORTDIR}/eclass and use the attached patch:
  patch -p0 < vim.eclass.patch
2. save the conceal patch (attached) to ${DISTDIR} (eg, /usr/portage/distfiles)
3. Enable the 'conceal' USE flag, and emerge vim and gvim
Comment 1 Moshe Kamensky 2004-09-25 14:08:19 UTC
Created attachment 40408 [details, diff]
patch for vim.eclass to (optionally) enable the conceal patch
Comment 2 Moshe Kamensky 2004-09-25 14:10:13 UTC
Created attachment 40409 [details, diff]
the conceal patch for vim
Comment 3 Ciaran McCreesh 2004-09-27 07:20:25 UTC
Hm, I'm very wary about applying such a large patch, especially after Bram has rejected it...
Comment 4 Moshe Kamensky 2004-09-27 10:03:57 UTC
I didn't know it was rejected by Bram! At least, it appears on the features 
voting page (http://vim.sourceforge.net/sponsor/vote_results.php). I guess it 
will become part of vim some time, Only no one knows when.

I find this patch very useful. There are several plugins that make use of it, 
including Dr. Chips' AnsiEsc.vim (script 302), and my own browser plugin 
(script 1053). And I made it depend on a USE flag, so it is not applied by 
default.
Comment 5 Ciaran McCreesh 2004-09-27 10:13:27 UTC
As I recall, Bram said no, and a lot of people complained, so he added it to the vote list.

The thing about this patch is... It's big, it touches a lot, and it's a real pain to maintain between vim versions. I know this because last time I was considering applying it the most up to date version of the patch failed to apply in several places :)
Comment 6 Moshe Kamensky 2004-09-27 11:12:20 UTC
Well, people appear to be maintaining it. For instance, http://cream.sf.net 
quiet updated windows binaries with this patch included.
Comment 7 Ryan Phillips (RETIRED) gentoo-dev 2004-09-27 17:57:34 UTC
I am in agreement with Ciaran.  The conceal patch will likely break after a simple version bump of vim patches.  I can't think of a simple way of keeping it in sync.
Comment 8 Ciaran McCreesh 2004-10-01 16:19:07 UTC
Think I'm gonna have to WONTFIX this. Sorry.