Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 651950 - media-video/yamdi-1.9 - Yet Another MetaData Injector for FLV
Summary: media-video/yamdi-1.9 - Yet Another MetaData Injector for FLV
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Default Assignee for New Packages
URL: http://yamdi.sourceforge.net/
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2018-03-29 21:00 UTC by Vieri
Modified: 2018-12-14 08:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
yamdi ebuild for v. 1.9 (yamdi-1.9.ebuild,837 bytes, text/plain)
2018-03-29 21:00 UTC, Vieri
Details
yamdi ebuild for v. 1.9 (yamdi-1.9.ebuild,640 bytes, text/plain)
2018-04-05 09:17 UTC, Vieri
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vieri 2018-03-29 21:00:28 UTC
Created attachment 526130 [details]
yamdi ebuild for v. 1.9

FLV indexer - new package
Comment 1 Jonas Stein gentoo-dev 2018-03-29 22:50:36 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman
* We always try to use the latest EAPI, please bump to EAPI=6
* Please remove obsolete lines
RDEPEND=""
DEPEND="${RDEPEND}"
RDEPEND="${RDEPEND}"
makes no sense and can be deleted.

* Please be more specific in the DESCRIPTION. The objective description may be <=80 characters long.
* after bumping to EAPI=6, drop eutils
* add "default" see: https://devmanual.gentoo.org/ebuild-writing/eapi/
* remove pkg_postinst()
* read also https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Comment 2 Vieri 2018-04-05 09:17:19 UTC
Created attachment 526592 [details]
yamdi ebuild for v. 1.9
Comment 3 Vieri 2018-04-05 09:22:20 UTC
# repoman -dx full

RepoMan scours the neighborhood...
  metadata.missing [fatal]      1
   media-video/yamdi/metadata.xml
Please fix these important QA issues first.
RepoMan sez: "Make your QA payment on time and you'll never see the likes of me."

I did not create a metadata.xml because I'm not the maintainer.

I understand that "default" is usually only for applying patches in src_prepare or calling emake in src_install if there's a Makefile provided upstream. Nothing for src_compile. So I don't really need to call "default". Infact, I'd rather not in src_install because there's an upstream Makefile but it's inappropriate.