Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 651946 - net-wireless/crda python3 support
Summary: net-wireless/crda python3 support
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-29 19:33 UTC by Boris Staletic
Modified: 2018-03-31 00:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
key2pu.py python3 patch (key2pub_py.diff,1.48 KB, patch)
2018-03-30 17:41 UTC, Boris Staletic
Details | Diff
Line added to ebuild to make use of the crda patch (ebuild.diff,478 bytes, patch)
2018-03-30 17:45 UTC, Boris Staletic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Staletic 2018-03-29 19:33:28 UTC
I have made the only python file (utils/key2pub.py) work on both python2 and python3.
The attached patch applies cleanly to the CRDA master as off Thu Mar 29 21:21:50 CEST 2018 and to the 3.18-r1 version.
The patch should apply cleanly to version 1.1.3-r1 too, but I couldn't test that one.

Granted, this patch is more suitable for upstream, but I couldn't find the correct way to submit CRDA patches.
Comment 1 Jonas Stein gentoo-dev 2018-03-29 22:39:06 UTC
please attach the patch as described here for logs:
https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket

Also explain what you did why.
Comment 2 Boris Staletic 2018-03-30 17:41:35 UTC
Created attachment 526166 [details, diff]
key2pu.py python3 patch
Comment 3 Boris Staletic 2018-03-30 17:45:27 UTC
Created attachment 526168 [details, diff]
Line added to ebuild to make use of the crda patch
Comment 4 Boris Staletic 2018-03-30 17:51:19 UTC
Sorry about that, somehow I missed the patch. I hope the patches make it clear what I have done, if not, feel free to ask.

Note that ebuild doesn't have the necessary `PYTHON_COMPAT` ammended, because it depends on dev-python/m2crypto having python3 USE flags enabled.

M2Crypto works with python3 upstream, but the ebuild in portage tree is lagging behind.
Comment 5 Ulenrich 2018-03-31 00:00:39 UTC
Workaround without patches of above but going back to stable:

emerge -C  dev-python/typing  dev-python/m2crypto   net-wireless/crda
echo "dev-python/m2crypto -~amd64" >>/etc/portage/package.accept_keywords
emerge -1 dev-python/m2crypto   net-wireless/crda

without dev-python/typing