Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 65086 - cvs commit does not mail gentoo-doc-cvs anymore
Summary: cvs commit does not mail gentoo-doc-cvs anymore
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Git (show other bugs)
Hardware: All All
: High major (vote)
Assignee: solar (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 64909
Blocks:
  Show dependency tree
 
Reported: 2004-09-23 06:21 UTC by Xavier Neys (RETIRED)
Modified: 2011-10-30 22:47 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mpipe.rb (mpipe.rb,872 bytes, text/plain)
2004-09-24 06:49 UTC, Xavier Neys (RETIRED)
Details
mpipe.rb (mpipe.rb,1.34 KB, text/plain)
2004-09-28 11:59 UTC, Xavier Neys (RETIRED)
Details
Requested patch on loginfo (loginfo.patch,1.22 KB, patch)
2004-09-28 12:00 UTC, Xavier Neys (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xavier Neys (RETIRED) gentoo-dev 2004-09-23 06:21:33 UTC
Doc writers and translators rely on the gentoo-doc-cvs mailing list to be notified of changes to the docs. A mail used to be sent on each commit.
It has stopped working, again.
Comment 1 Lars Weiler (RETIRED) gentoo-dev 2004-09-23 15:58:09 UTC
Problem is bug 64909.  With that bug a line has been added to CVS' loginfo, so that the ciabot takes care of gentoo/xml/htdocs -- the line for /doc/en follows after that.  Unfortunately the current cvs handles "first come, first serve" (this will be changed when the current development branch of cvs becomes stable).

Possible solution: We need a wrapper which will call ciabot _and_ the commitlog-script.  This would also be handy for the gentoo-x86-module.
Comment 2 Xavier Neys (RETIRED) gentoo-dev 2004-09-24 06:47:16 UTC
Unfortunately, interested parties have not been notified of any changes that may affect them, nor have they been asked for any help they might have offered.

What is this ciabot for and what does it do with the loginfo of the docs?
Why is it more important than the gentoo-doc-cvs mailing list?
Does it do anything useful to us?
Why not call it ciaobot?

Now, enough ranting ;-)
Comment 3 Xavier Neys (RETIRED) gentoo-dev 2004-09-24 06:49:48 UTC
Created attachment 40298 [details]
mpipe.rb

If all you need is something that outputs STDIN to multiple processes, here is
a very simple ruby script that does it.
Please let me know if it helps (or not) or if it needs to do more.
Comment 4 Xavier Neys (RETIRED) gentoo-dev 2004-09-27 03:26:34 UTC
Another bunch of changes to the docs...
It's almost impossible for translators to notice changes without the gentoo-doc-cvs mailing list.
Can we have it back, please?
Comment 5 Sven Vermeulen (RETIRED) gentoo-dev 2004-09-27 06:03:51 UTC
I agree wholeheartedly (sp?), having CIA log the htdocs changes might be fun, but the gentoo-doc-cvs mailinglist is something we desperately need.
Comment 6 Kurt Lieber (RETIRED) gentoo-dev 2004-09-27 11:35:21 UTC
solar -- adding the CIA stuff to CVS apparently broke the gentoo-doc-cvs mailing list.  Can you see about fixing this and/or removing the CIA stuff?
Comment 7 solar (RETIRED) gentoo-dev 2004-09-27 15:35:08 UTC
I updated the loginfo and replaced the ^gentoo\/xml\/htdocs string(s) after doing a
bash# find /var/cvsroot/gentoo/xml/htdocs -name en -type d | cut -d / -f 4- | grep -v doc/en


Hopefully this will be an acceptable compromise with the gentoo-doc-cvs mailinglist and the devs from bug #64909

TEST-REQUEST:
Can somebody please try committing a few somethings and confirming all is well?
Comment 8 Xavier Neys (RETIRED) gentoo-dev 2004-09-28 03:19:04 UTC
Thanks. We're almost there.
A commit of htdocs/doc/en/testfile triggered a mail but not in
/htdocs/proj/en/gdp/doc

FYI, we need the get notifications for files in
 htdocs/proj/en/gdp/doc/
 htdocs/doc/en/

It would make things clearer if we knew what's in the loginfo.

If you want the CIA bot to track those files as well, why not try script in #3 with an entry like
^gentoo\/xml\/htdocs\/proj\/en\/gdp\/doc mpipe.rb -pipe cvs-doc-cmd options -pipe cia-bot-cmd options
Comment 9 solar (RETIRED) gentoo-dev 2004-09-28 10:13:56 UTC
To get the module you can just cvs co CVSROOT.
But I'll paste hee for reference.

solar@simple CVSROOT $ cat loginfo 
# The "loginfo" file controls where "cvs commit" log information
# is sent.  The first entry on a line is a regular expression which must match
# the directory that the change is being made to, relative to the
# $CVSROOT.  If a match is found, then the remainder of the line is a filter
# program that should expect log information on its standard input.
#
# If the repository name does not match any of the regular expressions in this
# file, the "DEFAULT" line is used, if it is specified.
#
# If the name ALL appears as a regular expression it is always used
# in addition to the first matching regex or DEFAULT.
#
# You may specify a format string as part of the
# filter.  The string is composed of a `%' followed
# by a single format character, or followed by a set of format
# characters surrounded by `{' and `}' as separators.  The format
# characters are:
#
#   s = file name
#   V = old version number (pre-checkin)
#   v = new version number (post-checkin)
#
# For example:
#DEFAULT (echo ""; id; echo %s; date; cat) >> $CVSROOT/CVSROOT/commitlog
# or
#DEFAULT (echo ""; id; echo %{sVv}; date; cat) >> $CVSROOT/CVSROOT/commitlog
#^gentoo-x86		( /usr/local/sbin/cvsmail.sh $USER %s & )

# pylon@gentoo.org: On request by SwifT add commit-messages to the english docs by mail:
# I don't use ciabot because it seems to be changed for the IRC-stuff and does not fit the needs by the docs-team.
\/doc\/en       ( $CVSROOT/CVSROOT/commitlog-doc.pl %{s} )

## bug solar if cia this misbehaves.
^gentoo-x86	( $CVSROOT/CVSROOT/ciabot.pl %{s} $USER gentoo cvs-commits@gentoo.org cia@navi.cx ) 
^gentoo-src	( $CVSROOT/CVSROOT/ciabot.pl %{s} $USER gentoo cvs-commits@gentoo.org cia@navi.cx )

# Specifically, the gentoo/src and gentoo/xml modules, as this would
# allow stats to be kept on Gentoo-hosted projects, and also on the
# documentation/website, which I think definitely deserves some
# recognition since those guys are awesome. 
# Bug #64909 by request of Chris Gianelloni
^gentoo\/src	( $CVSROOT/CVSROOT/ciabot.pl %{s} $USER gentoo cvs-commits@gentoo.org cia@navi.cx )

# Unfortunately the current cvs handles "first come, first serve"
# fixed in upcomming development branch of cvs becomes stable.
# Bugzilla Bug 65086
#^gentoo\/xml\/htdocs	( $CVSROOT/CVSROOT/ciabot.pl %{s} $USER gentoo cvs-commits@gentoo.org cia@navi.cx )

# Workaround: replace with every dir worth while that is not 'doc/en'
^gentoo\/xml\/htdocs\/main ( $CVSROOT/CVSROOT/ciabot.pl %{s} $USER gentoo cvs-commits@gentoo.org cia@navi.cx )
^gentoo\/xml\/htdocs\/news ( $CVSROOT/CVSROOT/ciabot.pl %{s} $USER gentoo cvs-commits@gentoo.org cia@navi.cx )
^gentoo\/xml\/htdocs\/proj ( $CVSROOT/CVSROOT/ciabot.pl %{s} $USER gentoo cvs-commits@gentoo.org cia@navi.cx )
^gentoo\/xml\/htdocs\/security ( $CVSROOT/CVSROOT/ciabot.pl %{s} $USER gentoo cvs-commits@gentoo.org cia@navi.cx )
-------------------------------------------------------------------------------
If you would cvs co CVSROOT and make a diff/patch to the loginfo to how you think it should be that would be great.
Comment 10 solar (RETIRED) gentoo-dev 2004-09-28 11:09:45 UTC
As for the ruby script.

The cvs server does not have ruby installed. Ruby is not a base system package and starting up another interpreter is probably not going to be the best thing for low memory consumption. It also appears that both of the scripts would have to be modded to work correctly to work with it.
Comment 11 Xavier Neys (RETIRED) gentoo-dev 2004-09-28 11:59:13 UTC
Created attachment 40648 [details]
mpipe.rb

I know it's probably not going to be used, but just for the sake of accuracy:
reworked script to allow common args between multiplexed pgms because CVS
allows only one occurrence of %{s} per logfile entry.
Comment 12 Xavier Neys (RETIRED) gentoo-dev 2004-09-28 12:00:07 UTC
Created attachment 40649 [details, diff]
Requested patch on loginfo
Comment 13 Xavier Neys (RETIRED) gentoo-dev 2004-09-28 12:12:00 UTC
I can't do anything about ruby not being installed but `emerge ruby` seems logical ;-)
Its memory use is quite low, probably lower than perl's anyway.
See for yourself:
USER       PID %CPU %MEM   VSZ  RSS TTY      STAT START   TIME COMMAND
neysx     1373  0.0  0.4  6112 4276 ?        S    19:45   0:00 /usr/bin/ruby /home/neysx/gentoo.org/neysx.gentoo/trads/gorg/gorg

gorg is serving my local copy of www.g.o, a lot cheaper than apache and only 100 lines long.

Anyway, it's just to show that mailing the cvs-doc ML _and_ using the cia bot is possible. I am sure the same thing can be done in perl or python.
Comment 14 solar (RETIRED) gentoo-dev 2004-09-28 12:34:33 UTC
Xavier,
 Added your patch to CVSROOT/loginfo (please test)

Kurt,
 Any objections to ruby being installed on the cvs server?
Comment 15 Xavier Neys (RETIRED) gentoo-dev 2004-09-28 12:38:44 UTC
Just received emails for both directories.
Thanks.