Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 650852 - net-libs/rpcsvc-proto: enable support for -N and -M options
Summary: net-libs/rpcsvc-proto: enable support for -N and -M options
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 195461
  Show dependency tree
 
Reported: 2018-03-19 07:47 UTC by Andrew Savchenko
Modified: 2018-04-15 12:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
rpcsvc-proto-1.3.1.ebuild.patch (rpcsvc-proto-1.3.1.ebuild.patch,458 bytes, patch)
2018-03-19 07:47 UTC, Andrew Savchenko 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2018-03-19 07:47:55 UTC 
Created attachment 524358 [details, diff]
rpcsvc-proto-1.3.1.ebuild.patch

Hi!

net-libs/rpcsvc-proto has a regression compared to <=glibc-2.25[rpc] version: rpcgen lacks support of -M and -N options:

$ rpcgen -N -M -C -L -h -o l2tp_rpc.h l2tp_rpc.x
This implementation doesn't support newstyle or MT-safe code!

The code for -N and -M support is present, but disabled, because _RPC_THREAD_SAFE_ is not defined. libtirpc docs indicate that at least client-side the library is thread safe, so it should be reasonable to enable newstyle and MT-safe rpcgen code generators in order to be compatible with <=glibc-2.25.

Attached patch fixes this issue.
Comment 1 Andrew Savchenko gentoo-dev 2018-04-12 13:31:55 UTC 
Ping here! The change is simple. OK to commit?
Comment 2 Mike Gilbert gentoo-dev 2018-04-12 14:38:26 UTC 
It would probably make more sense to backport this:

https://github.com/thkukuk/rpcsvc-proto/pull/3

Please feel free to do that. :)
Comment 3 Pacho Ramos gentoo-dev 2018-04-15 12:45:54 UTC 
[master fb035e7aede7] net-libs/rpcsvc-proto: Drop obsolete preprocessor conditional (#650852)
 2 files changed, 61 insertions(+)
 create mode 100644 net-libs/rpcsvc-proto/files/rpcsvc-proto-1.3.1-old-preprocessor.patch
 create mode 100644 net-libs/rpcsvc-proto/rpcsvc-proto-1.3.1-r1.ebuild