Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 650096 - app-misc/pet uses pkg_postinstall(), not pkg_postinst()
Summary: app-misc/pet uses pkg_postinstall(), not pkg_postinst()
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Vladimir Pavljuchenkov (SpiderX)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-10 12:26 UTC by Sergei Trofimovich (RETIRED)
Modified: 2018-06-21 16:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich (RETIRED) gentoo-dev 2018-03-10 12:26:08 UTC
I did this typo myself today and wondered how many users to the same. Looks like not many:

$ git grep 'pkg_postinstall' | cat
app-misc/pet/pet-0.2.3-r1.ebuild:pkg_postinstall() {
app-misc/pet/pet-0.2.3.ebuild:pkg_postinstall() {
app-misc/pet/pet-0.2.4.ebuild:pkg_postinstall() {

While at it you might also consider using 'elog' instead of 'einfo'. 'einfo' is not seen when you build a package as '--quiet-build=y'.

diff --git a/app-misc/pet/pet-0.2.4-r1.ebuild b/app-misc/pet/pet-0.2.4-r1.ebuild
index baa71dab384..d2348553f42 100644
--- a/app-misc/pet/pet-0.2.4-r1.ebuild
+++ b/app-misc/pet/pet-0.2.4-r1.ebuild
@@ -53,5 +53,5 @@ src_install() {
 }
 
-pkg_postinstall() {
-       einfo "You should consider to install app-shells/peco to be able to use selector command"
+pkg_postinst() {
+       elog "${CATEGORY}/${PN}: You should consider to install app-shells/peco to be able to use selector command"
 }
Comment 1 Vladimir Pavljuchenkov (SpiderX) 2018-06-21 16:29:53 UTC
Fixed in https://github.com/gentoo/gentoo/commit/68c065abe3e6b7218e840122997f7b3dd1739af3