65001 – Patch to add icon drawing support to fbpanel's pager plugin

Bug 65001 - Patch to add icon drawing support to fbpanel's pager plugin

Summary: Patch to add icon drawing support to fbpanel's pager plugin

Status:	RESOLVED UPSTREAM

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	x86 Linux

Importance:	High enhancement (vote)
Assignee:	Commonbox Team

URL:	http://d.minuslab.net/fbpanel/pager_i...
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-09-22 11:31 UTC by Dave Foster
Modified:	2004-09-24 04:58 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
The patch to add icons to the pager plugin for fbpanel (pager_icons.patch,7.72 KB, patch) 2004-09-22 11:32 UTC, Dave Foster	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dave Foster 2004-09-22 11:31:33 UTC

This patch adds the ability to display icons for a window in the pager plugin for fbpanel.  The icons scale from 16x16 (max) down to 10x10 as needed by the size of the window's display.  Smaller windows and windows without icons do not have icons drawn on them.

Reproducible: Always
Steps to Reproduce:
1. patch -p1 < pager_icons.patch
2. make
3. ./fbpanel

Actual Results:  
fbpanel runs (with its default config), showing icons for the windows.

Expected Results:  
originally it has no icons, but this patch does hwat I expect it to do.

Portage 2.0.50-r11 (default-x86-2004.0, gcc-3.3.4, glibc-2.3.3.20040420-r1,
2.6.8-gentoo-r3)
=================================================================
System uname: 2.6.8-gentoo-r3 i686 AMD Athlon(tm) XP 2500+
Gentoo Base System version 1.4.16
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.5-r1
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=athlon-xp -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.2/share/config /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref
/usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=athlon-xp -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://mir.zyrianes.net/gentoo/ ftp://mir.zyrianes.net/gentoo/
http://ftp-stud.fht-esslingen.de/pub/Mirrors/gentoo/
ftp://ftp.easynet.nl/mirror/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aim alsa apache2 apm avi berkdb bitmap-fonts bonobo cdr crypt cups dvd
encode esd foomaticdb gd gdbm gif gnome gpm gtk gtk2 gtkhtml guile imlib java
jpeg ldap libg++ libwww mad mikmod motif mozilla mpeg mysql ncurses nls
oggvorbis opengl oss pam pdflib perl png python quicktime readline sdl slang
spell ssl svga tcltk tcpd truetype x86 xine xml2 xmms xprint xv zlib"

Comment 1 Dave Foster 2004-09-22 11:32:29 UTC

Created attachment 40175 [details, diff]
The patch to add icons to the pager plugin for fbpanel

Comment 2 Ciaran McCreesh 2004-09-22 13:43:33 UTC

Probably best if you send this upstream.

Comment 3 Dave Foster 2004-09-24 04:58:39 UTC

Will send patch upstream.