Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 649254 - app-portage/gemato-11.2: need ability to retry gpg refresh when it fails
Summary: app-portage/gemato-11.2: need ability to retry gpg refresh when it fails
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-01 18:14 UTC by Zac Medico
Modified: 2018-03-01 21:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-03-01 20:56:58 UTC
What's it supposed to do? Bash the server in the hope some attempt will succeed?

If the servers are having problems, then servers need to address that.

Gemato does key refresh as the very first thing it does. So does current portage.git (it refreshes keys even before doing rsync). If someone wants to retry, he can run the command again.
Comment 2 Zac Medico gentoo-dev 2018-03-01 20:59:43 UTC
Are you suggesting that portage should call gemato multiple times until it succeeds? I'm afraid that's not acceptable.
Comment 3 Zac Medico gentoo-dev 2018-03-01 21:06:54 UTC
If gemato doesn't have the ability to retry the gpg key refresh, then portage is going to have to do it. Every thing that network client thing that portage does needs retry support.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-03-01 21:14:50 UTC
Portage *does not* call gemato. It uses its API. This API includes refresh_keys() method. As the name says, it refreshes keys *once*. I won't turn it into bash_the_server_until_it_bans_you().
Comment 5 Zac Medico gentoo-dev 2018-03-01 21:33:31 UTC
(In reply to Michał Górny from comment #4)
> Portage *does not* call gemato. It uses its API.

I was thinking in terms of portage-2.3.24 which calls the gemato binary, and is due for stabilization soon. I suppose we can disable the rsync-verify USE flag default, until we have retry / backoff support integrated into portage.

> This API includes refresh_keys() method. As the name says, it refreshes keys
> *once*. I won't turn it into bash_the_server_until_it_bans_you().

That's fair enough, I see that it raises an OpenPGPKeyRefreshError that portage can handle. Thanks for the info!