648134 – app-admin/puppet-4.10.10 - master doesn't talk SSL

Bug 648134 - app-admin/puppet-4.10.10 - master doesn't talk SSL

Summary: app-admin/puppet-4.10.10 - master doesn't talk SSL

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal major (vote)
Assignee:	Matthew Thode ( prometheanfire )

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2018-02-19 16:59 UTC by Evert
Modified:	2018-02-20 06:28 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
emerge --info (emerge--info.txt,6.16 KB, text/plain) 2018-02-19 17:02 UTC, Evert	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Evert 2018-02-19 16:59:27 UTC

puppet-4.10.10 master doesn't talk SSL. This is caused by puppet-4-webrick-ruby.patch which removes sock.accept from webrick.rb. Restoring sock.accept makes puppet master working again. This applies to ruby22 & ruby23 as well.
I'm aware of https://tickets.puppetlabs.com/browse/PUP-8297 and
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224623
and I understand that issue should have been fixed in puppet-4.10.10. The removal of sock.accept breaks master/agent communication, so please restore sock.accept into puppet-4.10.10.

Note: tested using puppet agent, openssl s_client & telnet. Both tested using ruby22 & ruby23

Reproducible: Always

Comment 1 Evert 2018-02-19 17:02:41 UTC

Created attachment 520134 [details]
emerge --info

Comment 2 Hans de Graaff gentoo-dev

2018-02-20 06:17:22 UTC

Fixed in puppet 4.10.10-r1

commit f668591b65d1c01f8849f33670b4d14f3087f094
Author: Hans de Graaff <graaff@gentoo.org>
Date:   Mon Feb 19 10:56:15 2018 +0100

    app-admin/puppet: drop webrick patch for newer rubies
    
    This issue is fixed in 4.10.10 in a more complete way, and the old fix,
    which does not clash with the new fixes, now breaks things.

Comment 3 Hans de Graaff gentoo-dev

2018-02-20 06:28:57 UTC

I have also added puppet 5.4.0-r1 without the webrick patch because the same issue should apply there.