Created attachment 520036 [details] build.log app-crypt/efitools-1.7.0 fails to build with >=dev-libs/openssl-1.1.0, with errors regarding dereferencing pointers to incomplete types, and several warnings about using undeclared functions. This is due to changes in OpenSSL 1.1.0: internal structures are now opaque, and a lot of functions were deprecated/removed. Upstream has a new version (1.8.0, see [0]) with some fixes for OpenSSL 1.1.0. However a simple version bump is not enough, there are still some calls to undeclared functions, so the build still fails. I'm attaching below a patch against efitools-1.8.0 that restores compatibility with Gentoo's OpenSSL 1.1.0 (this has been sent upstream). [0]: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/efitools.git
Created attachment 520038 [details, diff] efitools-1.8.0-openssl-1.1.0-compat.patch
I made n PR for a version bump to 1.8.1 and added your patch also, as it compiles still fine.
Do you want to proxy maintain it? https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers Also, does any of you have a link to track the forward of the patch to upstream? Thanks
I finally got around to adjusting the patch as per upstream request, and resent it a few days ago. Still waiting for a reply, however I don't have any link to share since it's good ol' 1-on-1 email, there's no mailing list. I'd be ok with being the designated proxy maintainer for this package (I already am for another package), unless Conrad wants to step in. :)
(In reply to Quentin Minster from comment #4) > I'd be ok with being the designated proxy maintainer for this package (I > already am for another package), unless Conrad wants to step in. :) No, you can proxy maintain, if you wish :)
can you attach the latest patch against efitools-1.8.1 ?
It doesn't need updating. The patch against efitools-1.8.0 still applies.
(In reply to Quentin Minster from comment #7) i'm aware the patch you attached here applies on top of 1.8.0. you said in comment #4 that you adjusted the patch per upstream requests which means the patch attached originally is not the updated one.
(In reply to Conrad Kostecki from comment #2) > I made n PR for a version bump to 1.8.1 and added your patch also, as it > compiles still fine. I see that the PR was merged but I don't see the openssl patch
(In reply to Pacho Ramos from comment #9) > (In reply to Conrad Kostecki from comment #2) > > I made n PR for a version bump to 1.8.1 and added your patch also, as it > > compiles still fine. > > I see that the PR was merged but I don't see the openssl patch That it correct. As Quentin said in #4 that there is a newer version, the PR was without patch. I have expected, that there will be a newer one. As said also in #7.
Reassign efitools bugs to me.
Since we decided to no longer build openssl without deprecated features, this bug can now be considered as fixed (but will eventually reappear once openssl upstream finally removed deprecated features from their code).
