Created attachment 519406 [details] app-editors/scite-4.0.3 with new >=sys-devel/gcc-7 build dependency A new Version is available upstream. unfortunately it requires gcc-7, but with unstable 7.3 it compiles fine. Please add to tree. Thanks Ervin
Just reverting this patch allows me to compile with sys-devel/gcc-6.4.0-r1:1 https://github.com/mirror/scintilla/commit/9bae9af269dfad321a7248ceea613a74859d803d#diff-7050d062c911ebddec600c01dc5fa59b
(In reply to Chris Mayo from comment #1) > Just reverting this patch allows me to compile with sys-devel/gcc-6.4.0-r1:1 > > https://github.com/mirror/scintilla/commit/ > 9bae9af269dfad321a7248ceea613a74859d803d#diff- > 7050d062c911ebddec600c01dc5fa59b That is fine, but what do you think: It is worth to revert the upstream modernizations for this small bugfix release? I do not. I'd prefer to keep the ebuild and testing simple. The functionallity is availabel in 4.0.2 which hopefully gets stable soon. And gcc > 7 will get stable in the next years, maybe months or weeks too ;). ervin
That's all valid. It's a trade-off between two things that are unknowable: - will that be the only GCC 6 incompatible change in SciTE? - when will GCC 7 be stabilised? I don't mind (I've got the patch anyway!), just posting for completeness in case anyone is interested.
Now it is Version 4.1.0, and gcc-7 is stable. the ebuild works... ervin (proxied M.)
Sorry for the review delay. Using dependencies is not sufficient to ensure that the proper version of GCC is used. Use toolchain-funcs functions in pkg_pretend() to do that. You can grep for "gcc-major-version" for examples. For example, see xorg-server.
Created attachment 551276 [details] scite-4.1.2.ebuild added a pkg_pretend gcc-7 check. builds fine. ervin
...see pr #10159.
You haven't followed up on your own PR for more than a month. Are you still interested in proxy-maintaining this package?
(In reply to Virgil Dupras from comment #8) > You haven't followed up on your own PR for more than a month. Are you still > interested in proxy-maintaining this package? Funny guys! Your kidding! In the past I wait for month, one time nearly a year for a response or an activity from proxy maintainers. It is a very bad leading habit to recommend something from proxied maintainers which the proxy maintainers did not do... Yes I'll do it further on. And yes sometime probably at christmas I take a look at all the recommendations of the git pull request and get it repaired. Ervin Peters
2. try: https://github.com/gentoo/gentoo/pull/10534 It seems that I didn't find a handy complete manual to make a pull request as Proxy maintainer. Or I did some mistakes. Any Ideas to fix? ervin
Hello Ervin, thanks for your work and sorry for all misunderstandings. I tried to bump your pr and I got: remote: FATAL: VREF/proj-gentoo-06-copyright: helper program exit status 256 remote: 80f289816dd0220e52ba615e825a42996c00a300: malformed Signed-off-by (should be: real name <email>)! remote: Signed-off-by: Ervin Peters ervin.peters@ervnet.de I modified the PR manually, but next time please include the <>
