Bug 647196 – app-misc/dejsonlz4-1.1 - Decompress Mozilla Firefox bookmarks backup files

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description thyr 2018-02-10 01:05:01 UTC]

Created attachment 518882 [details]
dejsonlz4-1.1.ebuild

Hello.

From https://github.com/avih/dejsonlz4:

> Current Firefox bookmarks backup files are stored as non-standard file format based on lz4 compression. These files have a .jsonlz4 extension. Use dejsonlz4 to decompress them.

app-arch/dejsonlz4 suggested.

[Comment 1 Jeroen Roovers (RETIRED) 2018-02-10 12:23:03 UTC]

Comment on attachment 518882 [details]
dejsonlz4-1.1.ebuild

># Copyright 1999-2018 Gentoo Foundation
># Distributed under the terms of the GNU General Public License v2
>
>EAPI=6
>
>DESCRIPTION="Decompress Mozilla Firefox bookmarks backup files"
>HOMEPAGE="https://github.com/avih/dejsonlz4/"
>SRC_URI="https://github.com/avih/dejsonlz4/archive/v1.1.zip"

If every ebuild did this, DISTDIR would be full of things named "v{version}.zip". We instead use redirects that looks like this:

     https://github.com/avih/dejsonlz4/archive/v1.1.zip -> ${P}.zip

where ${P} stands for ${PN}-${PV} and
where ${PN} is the package name and
where ${PV} is the package version.

>
>LICENSE="BSD-2"
>SLOT="0"
>KEYWORDS="~amd64 ~x86"
>
>src_install() {

This is the build phase where you install things.

>  gcc -Wall -o dejsonlz4 src/dejsonlz4.c src/lz4.c

The build phase that compiles things is src_compile() not src_install().

Your ebuild should respect the compiler executable set in the CC variable instead of hard-coding "gcc".
Your ebuild should use the compiler flags set in the CFLAGS variable.

>  dobin dejsonlz4
>}

[Comment 2 thyr 2018-02-11 20:46:22 UTC]

Created attachment 519126 [details]
dejsonlz4-1.1.ebuild: fixed SRC_URI; src_compile added

[Comment 3 thyr 2018-02-11 20:49:01 UTC]

(In reply to Jeroen Roovers from comment #1)
> Comment on attachment 518882 [details]
> dejsonlz4-1.1.ebuild
> 
> ># Copyright 1999-2018 Gentoo Foundation
> ># Distributed under the terms of the GNU General Public License v2
> >
> >EAPI=6
> >
> >DESCRIPTION="Decompress Mozilla Firefox bookmarks backup files"
> >HOMEPAGE="https://github.com/avih/dejsonlz4/"
> >SRC_URI="https://github.com/avih/dejsonlz4/archive/v1.1.zip"
> 
> If every ebuild did this, DISTDIR would be full of things named
> "v{version}.zip". We instead use redirects that looks like this:
> 
>      https://github.com/avih/dejsonlz4/archive/v1.1.zip -> ${P}.zip
> 
> where ${P} stands for ${PN}-${PV} and
> where ${PN} is the package name and
> where ${PV} is the package version.
> 
> >
> >LICENSE="BSD-2"
> >SLOT="0"
> >KEYWORDS="~amd64 ~x86"
> >
> >src_install() {
> 
> This is the build phase where you install things.
> 
> >  gcc -Wall -o dejsonlz4 src/dejsonlz4.c src/lz4.c
> 
> The build phase that compiles things is src_compile() not src_install().
> 
> Your ebuild should respect the compiler executable set in the CC variable
> instead of hard-coding "gcc".
> Your ebuild should use the compiler flags set in the CFLAGS variable.
> 
> >  dobin dejsonlz4
> >}

Sorry. Fixed version: https://bugs.gentoo.org/attachment.cgi?id=519126

[Comment 4 tt_1 2023-08-29 19:18:35 UTC]

you def. should update that eapi