Bug 64620 – New speakup patch

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jeremy Huddleston (RETIRED) 2004-09-19 04:39:10 UTC]

I've created a new patch for speakup which should allow it to work on ppc and amd64.  The patch SHOULD be able to simply replace the old one.  I created it by 'patch -R'ing the old one, applying the changes, removing all .orig files, and diffing the two trees...  Please let me know if there is any trouble with it.

[Comment 1 Jeremy Huddleston (RETIRED) 2004-09-19 04:40:31 UTC]

Created attachment 39909 [details, diff]
4905_speakup-20040919.patch

[Comment 2 Daniel Drake (RETIRED) 2004-10-02 06:15:41 UTC]

Thanks for your work Jeremy. Included in gentoo-dev-sources-2.6.8-r6

[Comment 3 Daniel Drake (RETIRED) 2004-10-08 18:14:13 UTC]

FYI with this patch applied, 2.6.9-rc3-bk8 fails at the linking stage (undefined references)

[Comment 4 Jeremy Huddleston (RETIRED) 2004-10-12 02:02:54 UTC]

Created attachment 41603 [details, diff]
/usr/src/4905_speakup-20041012.patch

applies against vanilla 2.6.9-rc4
vanilla 2.6.9-rc4 + this patch compiles/links fine on amd64 given:

CONFIG_SPEAKUP=y
CONFIG_SPEAKUP_SFTSYN=m
CONFIG_SPEAKUP_DEFAULT="sftsyn"

[Comment 5 Daniel Drake (RETIRED) 2004-10-15 19:24:21 UTC]

Could you please try booting with this?
On x86 I get an immediate oops (relating to atkbd_init and things like that), if you need me to be more specific just ask. I'll investigate further tomorrow, its rather late..

[Comment 6 Daniel Drake (RETIRED) 2004-10-15 19:24:47 UTC]

Oh forgot to mention, speakup isnt even enabled in my .config

[Comment 7 Daniel Drake (RETIRED) 2004-10-16 04:12:08 UTC]

Yep.. just tested on an otherwise clean 2.6.9-rc4-bk3 and there are actually 2 oops's on bootup but the first one is pushed off the screen. Please could you look into this? 2.6.9 is coming out soon, and we're considering gentoo-dev-sources-2.6.9 for the 2004.3 LiveCD - it would at least be nice to have the option when the time comes. Thanks!

[Comment 8 Daniel Drake (RETIRED) 2004-10-16 05:54:18 UTC]

Reverting the changes to drivers/Makefile gets rid of the oops, but I guess this breaks speakup?

[Comment 9 Jeremy Huddleston (RETIRED) 2004-10-17 01:37:51 UTC]

If we can't get 2.6.9 to work with speakup in time for the 2004.3 release, can we atleast include the latest 2.6.8 kernel on the ppc, amd64, and x86 livecds?

[Comment 10 Daniel Drake (RETIRED) 2004-10-17 04:34:07 UTC]

Yes thats the plan.. I've already spoken to the relevant people.

[Comment 11 Jeremy Huddleston (RETIRED) 2004-10-20 15:05:13 UTC]

Created attachment 42275 [details, diff]
4905_speakup-20041020.patch

Here's a new patch that works against 2.6.9-gentoo

Email I recieved from upstream:
Hi Jeremy:  I went to the bug reporting page but couldn't figure out
easily how to add new comments so I am writing you instead.  I have
made changes to speakup today on release of the 2.6.9 kernel.  The
problem mostly was that the input keyboard registration system has
been moved into the serio module and we were loading the input
configuration modules before the serio module.	I have moved the
entries around in drivers/Makefile and it looks like that fixed the
problem.  I have tested it on the DoubleTalk internal synth and the
Transport external so far.

I also had to move where the mips architecture called the speakup
Kconfig file so someone with some type of mips will have to test that.

The changes have been made in cvs.
  Kirk

[Comment 12 Chris Gianelloni (RETIRED) 2004-10-21 22:17:24 UTC]

Well... we're planning on using 2.6.9 for amd64 and x86 and I know ppc is doing the same... I guess you guys can close this one.

[Comment 13 Deedra Waters (RETIRED) 2004-10-21 22:19:53 UTC]

I'll close it since i'm running the 2.6.9 kernel with speakup on my workstation, and I haven't broken it yet:)