Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 64606 - Enigmail in Thunderbird 1.0.2 has wrong themed icons
Summary: Enigmail in Thunderbird 1.0.2 has wrong themed icons
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High minor
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on: 64547
Blocks:
  Show dependency tree
 
Reported: 2004-09-19 02:05 UTC by Matteo Settenvini
Modified: 2005-06-23 11:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
This shows the wrong icons (engimail-wrongicons01.png,58.01 KB, image/png)
2004-09-19 02:06 UTC, Matteo Settenvini
Details
Patch for mozilla-thunderbird-1.0.ebuild (tb-enigmail-icons.patch,953 bytes, patch)
2004-12-09 07:52 UTC, Thierry Carrez (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matteo Settenvini 2004-09-19 02:05:56 UTC
See attached screenshot...

Using Thunderbird 0.8 + Enigmail 0.86.0.0
Comment 1 Matteo Settenvini 2004-09-19 02:06:41 UTC
Created attachment 39901 [details]
This shows the wrong icons

Here there are the icons with the wrong theme.
Comment 2 Aron Griffis (RETIRED) gentoo-dev 2004-11-17 19:43:45 UTC
Upstream enigmail bug, not something we're going to fix in the distribution.
Comment 3 Thierry Carrez (RETIRED) gentoo-dev 2004-12-05 10:28:12 UTC
Aron: according to enigmail developers, this is due to the way we install enigmail. I don't see where we click buttons or anything, but they say it's not a bug on their side :

http://bugzilla.mozdev.org/show_bug.cgi?id=5243

With previous versions, there was the option of building Thunderbird with USE=-crypt and install enigmail as a user (in which case the icons would be OK), but it seems to be broken now that they regrouped the enigmime and enigmail plugins :)

Would there be a way to workaround this on our side at build time or to patch enigmail afterwards to get the icons right ?
Comment 4 Thierry Carrez (RETIRED) gentoo-dev 2004-12-09 07:52:44 UTC
Created attachment 45609 [details, diff]
Patch for mozilla-thunderbird-1.0.ebuild

Here is a quick and dirty patch.

The problem comes from we don't go through the install.js file to register
enigmail so we use enigmail-skin.jar by default. What the patched ebuild does
is to copy the enigmail-skin-tbird.jar file over the enigmail-skin.jar during
src_install, before the extension is registered. Note that using mv instead of
cp might also work and be cleaner.

Tested and working on the 1.0.ebuild.
Comment 5 Thierry Carrez (RETIRED) gentoo-dev 2005-03-26 10:16:23 UTC
This is still a problem in TB-1.0.2, and the provided patch still fixes it.
Comment 6 Matteo Settenvini 2005-06-23 02:12:25 UTC
Ain't seeing this bug resolved fixed for Mozilla Thunderbird 1.0.2-r1, released
today.

This bug is nine months old, yet unfixed although having a (four lines long)
working patch for the ebuild. 

It's starting to smell badly, you know.
Comment 7 Aron Griffis (RETIRED) gentoo-dev 2005-06-23 11:00:55 UTC
Sorry for the long wait on this.  Thanks for doing the research and providing a
patch.  Fixed in 1.0.2-r1 in cvs.  I did not bother to bump the rev because I'm
working on a few other problems which will eventually result in a revbump anyway.

http://www.gentoo.org/cgi-bin/viewcvs.cgi/mail-client/mozilla-thunderbird/mozilla-thunderbird-1.0.2-r1.ebuild?r1=1.1&r2=1.2