64514 – Logic error in gen_package.sh

Bug 64514 - Logic error in gen_package.sh

Summary: Logic error in gen_package.sh

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Hosted Projects
Classification:	Unclassified
Component:	genkernel (show other bugs)
Hardware:	All All

Importance:	High normal
Assignee:	Gentoo Genkernel Maintainers

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:

Reported:	2004-09-18 06:03 UTC by Guy Martin (RETIRED)
Modified:	2004-09-27 08:32 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Guy Martin (RETIRED) gentoo-dev

2004-09-18 06:03:26 UTC

The line
[ "${BUILD_INITRD}" -ne 0 ] && cp "${TEMP}/initrd-${KV}" "${TEMP}/minkernpackage/initrd-${KV}" || gen_die 'Could not copy the initrd for the kernel package!'

in gen_package.sh is totally wrong !

If BUILD_INITRD=0 and a package build is requested, this will ALWAYS fail.

This line is correct :

[ "${BUILD_INITRD}" -ne 0 ] && ( cp "${TEMP}/initrd-${KV}" "${TEMP}/minkernpackage/initrd-${KV}" || gen_die 'Could not copy the initrd for the kernel package!' )

Comment 1 Daniel Drake (RETIRED) gentoo-dev

2004-09-26 07:19:11 UTC

gen_package.sh is part of genkernel, right?

Comment 2 Tim Yamin (RETIRED) gentoo-dev

2004-09-26 10:50:36 UTC

This was fixed in CVS and 3.0.2g; marking bug as such.

Comment 3 Chris Gianelloni (RETIRED) gentoo-dev

2004-09-27 08:32:40 UTC

This one bit me a couple times, I think... adding livecd@ just so it'll show up in my queue and I can be sure to seriously razz plasmaroo if it isn't fixed... *grin*