Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 644086 - Manifest and DOCKER_GITCOMMIT for app-emulation/docker-17.12.0 are wrong
Summary: Manifest and DOCKER_GITCOMMIT for app-emulation/docker-17.12.0 are wrong
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major
Assignee: Manuel Rüger (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-10 00:59 UTC by Edward Jee
Modified: 2018-01-10 18:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Edward Jee 2018-01-10 00:59:05 UTC
If we download https://github.com/docker/docker-ce/archive/v17.12.0-ce.tar.gz , it's size is 11008332.

And the git tag "v17.12.0-ce" of docker-ce points to commit "c97c6d62c26c1da407e3086f0b5d3d866ed308bc".
(As seen at https://github.com/docker/docker-ce/releases/tag/v17.12.0-ce .)

However, the Manifest file says the docker 17.12.0's tarball file size is 11011208 , which looks wrong. This must be 11008332. And I gueess the corresponding SHA512 should be fixed as well.
(https://gitweb.gentoo.org/repo/gentoo.git/tree/app-emulation/docker/Manifest#n3 )

Also, docker-17.12.0.ebuild has "DOCKER_GITCOMMIT=486a48d", which seems also wrong. This must be "c97c6d6".
(https://gitweb.gentoo.org/repo/gentoo.git/tree/app-emulation/docker/docker-17.12.0.ebuild#n20 )

A few days ago, I believe docker-ce's tag "v17.12.0-ce" used to point to the commit "486a48d", which is actually not in 17.12 branch but in 18.01 branch. I guess Docker maintainers tagged a wrong commit by mistake. Now the tag "v17.12.0-ce" correctly points to "c97c6d6". I guess they fixed it very recently.

Hence, the file https://github.com/docker/docker-ce/archive/v17.12.0-ce.tar.gz is different from what it used to be a few days ago. If it was fetched to any mirror, the mirror should be updated as well.
Comment 1 Manuel Rüger (RETIRED) gentoo-dev 2018-01-10 18:38:07 UTC
Apparently, they retagged it without telling anyone. https://github.com/docker/docker-ce/commit/c97c6d62c26c1da407e3086f0b5d3d866ed308bc#commitcomment-26664506


Thanks for the report!

Fixed in b6126df88dc1957534ea6e0234cc76d24fcae5a8