Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 642752 - games-strategy/colobot (new ebuild)
Summary: games-strategy/colobot (new ebuild)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2017-12-30 18:29 UTC by Martin Doucha
Modified: 2018-03-16 07:11 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Latest official release (colobot-0.1.11.ebuild,1.39 KB, text/plain)
2017-12-30 18:29 UTC, Martin Doucha
Details
Live ebuild (colobot-9999.ebuild,1.12 KB, text/plain)
2017-12-30 18:37 UTC, Martin Doucha
Details
Latest official release (colobot-0.1.11.ebuild,1.41 KB, text/plain)
2018-01-05 12:24 UTC, Martin Doucha
Details
Live ebuild (colobot-9999.ebuild,1.11 KB, text/plain)
2018-01-05 12:25 UTC, Martin Doucha
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Doucha 2017-12-30 18:29:41 UTC
Created attachment 512070 [details]
Latest official release

I'd like to submit an ebuild for Colobot Gold, an open-source strategy game where the player learns to code by programming robots to colonize planets.

Official website: https://colobot.info/
Comment 1 Martin Doucha 2017-12-30 18:37:44 UTC
Created attachment 512072 [details]
Live ebuild

egit-r3 will complain that the colobot-data submodule URI is insecure. But the module contains only game assets and in-game scripts. Unless the game engine (in the main repository) contains a code execution bug, it should be fine.
Comment 2 tsmksubc 2017-12-31 09:28:15 UTC
I have colobot in my overlay https://notabug.org/soredake/gentoo-overlay/src/master/games-strategy/colobot, i can be maintainer of this package.
Comment 3 Jonas Stein gentoo-dev 2018-01-05 07:28:23 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman full -x https://wiki.gentoo.org/wiki/Repoman
* commands which are not from helpers (like rm, mv, cp) need || die
* do you really need the large eutils?
* perhaps split data and the game in two packages?
Comment 4 Martin Doucha 2018-01-05 12:24:00 UTC
Created attachment 513392 [details]
Latest official release

Ebuild fixed according to suggestions. But splitting the ebuild is probably pointless. Both source code and data tarballs are always released together with shared version number and the live ebuild pulls the data automatically. Split ebuild would just make routine maintenance more time-consuming.
Comment 5 Martin Doucha 2018-01-05 12:25:32 UTC
Created attachment 513394 [details]
Live ebuild
Comment 6 tsmksubc 2018-01-05 13:32:14 UTC
pr: https://github.com/gentoo/gentoo/pull/6756
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-03-16 07:11:07 UTC
It has been merged apparently.