Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 642110 - sys-fs/zfs-kmod - Impossible to build if kernel patched in with Reiser4 fs support
Summary: sys-fs/zfs-kmod - Impossible to build if kernel patched in with Reiser4 fs su...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Richard Yao (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-23 13:10 UTC by Denis Descheneaux
Modified: 2018-01-09 00:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Descheneaux 2017-12-23 13:10:53 UTC
sys-fs/zfs-kmod seems to be impossible to merge if you have a kernel installed and patched with Reiser4 FS support

Suggestion to add to the zfs-kmod ebuild

So that it will at the very least fail building while saying what option should not be enabled, probably add some ewarn notes about it, this issue is not easy to spot if you dont know what you are looking for

pkg_setup() {
	# Fails to build if you have reiser4 kernel support patched in kernel
	linux-info_pkg_setup
	CONFIG_CHECK="!DEBUG_LOCK_ALLOC
+		!CONFIG_REISER4_FS
		EFI_PARTITION

With this set and after cleaning up without reiser4 fs kernel support, package will build successfully
Comment 1 Denis Descheneaux 2017-12-23 13:16:47 UTC
pkg_setup() {
+	# Fails to build if you have reiser4 kernel support patched in kernel
	linux-info_pkg_setup
	CONFIG_CHECK="!DEBUG_LOCK_ALLOC
+		!CONFIG_REISER4_FS
		EFI_PARTITION
Comment 2 Jonathan Vasquez (RETIRED) gentoo-dev 2018-01-03 18:16:34 UTC
That's correct. ZFS and reiser4 are incompatible to be installed at the same time. Reiser4 is an out of tree kernel module and there are no plans or collaboration happening between the ZoL and Reiser4 teams to guarantee that their filesystems can peacefully coexist within the mainline kernel.
Comment 3 Jonathan Vasquez (RETIRED) gentoo-dev 2018-01-03 18:17:30 UTC
If you need this feature, please open up a bug report with upstream ZoL and see if they want to work with reiser4 team to fix this.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-01-03 19:07:58 UTC
Jonathan, he was asking to express this incompatibility explicitly so that people wouldn't have to figure out why things are failing.
Comment 5 Jonathan Vasquez (RETIRED) gentoo-dev 2018-01-03 19:48:11 UTC
Ah sorry for the misinterpretation. Sure, sounds like a good idea to explicitly add this message. I'll re-open this and add it later.
Comment 6 Denis Descheneaux 2018-01-04 03:42:19 UTC
Exactly was not explicitly using the Reiser4 FS anymore but it was still patched in my kernels, after this i did leave it out, just so that others dont fall in the same trap :)
Comment 7 Jonathan Vasquez (RETIRED) gentoo-dev 2018-01-08 23:28:53 UTC
Thanks Denis. I added the !CONFIG_REISER4_FS check to all ZFS ebuilds.

The commit can be found here:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df1cc0f5f518b877bc29d7b0fa15456203041d0f
Comment 8 Jonathan Vasquez (RETIRED) gentoo-dev 2018-01-09 00:00:43 UTC
For note, Richard Yao just submitted a patch for this on ZFS on Linux's repo:

https://github.com/zfsonlinux/zfs/pull/7021