Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 641544 - www-client/chromium-64.0.3282.24 with sys-devel/gcc-5.4.0-r3 - ../../gpu/ipc/common/mailbox_struct_traits.h:18:20: error: could not convert ‘(c onst int8_t*)(& mailbox.gpu::Mailbox::name)’ from ‘const int8_t* {aka const sign ed char*}’ to ‘base::span<cons
Summary: www-client/chromium-64.0.3282.24 with sys-devel/gcc-5.4.0-r3 - ../../gpu/ipc/...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-18 10:54 UTC by Martin von Gagern
Modified: 2018-07-29 19:23 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for chromium-64 gcc5 compat (chromium-64.0.3282.140-gcc5.patch,4.09 KB, patch)
2018-02-14 09:03 UTC, Sven Wegener
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2017-12-18 10:54:28 UTC
In file included from gen/gpu/ipc/common/mailbox_holder.mojom.cc:30:0:
../../gpu/ipc/common/mailbox_struct_traits.h: In static member function ‘static 
base::span<const signed char> mojo::StructTraits<gpu::mojom::MailboxDataView, gp
u::Mailbox>::name(const gpu::Mailbox&)’:
../../gpu/ipc/common/mailbox_struct_traits.h:18:20: error: could not convert ‘(c
onst int8_t*)(& mailbox.gpu::Mailbox::name)’ from ‘const int8_t* {aka const sign
ed char*}’ to ‘base::span<const signed char>’
     return mailbox.name;
                    ^

This looks like a regression of bug 628284: the issue was fixed for chromium 62 and 63 but now resurfaced with 64.

Yes, I know that I should be migrating to Gentoo 17 profile and in the process should switch to gcc 6.4.0 or later. But before I do so I'd like to get my system up to latest version, which is when I noticed this. Please keep gcc 5 compatibility around a while longer to give people a chance to migrate in their own time.

Once you officially stop supporting gcc 5, it might make sense to have an early check in the ebuild that gcc 6+ is not only installed but actually selected, or some such, to avoid a lengthy build that is bound to fail.
Comment 1 Mike Gilbert gentoo-dev 2017-12-23 18:32:51 UTC
If you can find/write a patch for this, I would be happy to apply it.
Comment 2 Sven Wegener gentoo-dev 2018-02-14 09:03:16 UTC
Created attachment 519404 [details, diff]
patch for chromium-64 gcc5 compat

The issue is that the gcc5 compat patches have been removed during the version bump. Here is an updated patch for chromium 64.
Comment 3 Oleh 2018-02-20 04:00:33 UTC
proposed patch allows to compile chromium-64 with gcc-5.4.0
Comment 4 Ivan Iraci 2018-03-13 11:51:10 UTC
May we have a patch for chromium >= 65?

Thanks in advance.
Comment 5 Ivan Iraci 2018-04-03 17:37:48 UTC
ping
Comment 6 Mike Gilbert gentoo-dev 2018-04-03 18:12:25 UTC
Please do not "ping" the bug report. If/when I have time to look at it, I will.
Comment 7 Ivan Iraci 2018-04-03 18:17:37 UTC
Take your time. 

I was only looking for an ack, because my previous comment had no answer.

"If/when I have time to look at it, I will." is a perfectly reasonable answer for me. Thank you.
Comment 8 Mike Gilbert gentoo-dev 2018-07-29 19:23:58 UTC
The chromium ebuilds force clang now.