640770 – www-client/firefox-52.5.2: build fails with "‘mozilla::gfx ::ShapedTextFlags’ has not been declared"

Bug 640770 - www-client/firefox-52.5.2: build fails with "‘mozilla::gfx ::ShapedTextFlags’ has not been declared"

Summary: www-client/firefox-52.5.2: build fails with "‘mozilla::gfx ::ShapedTextFlags’...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Mozilla Gentoo Team

URL:
Whiteboard:
Keywords:

Duplicates (1):	640826 (view as bug list)
Depends on:
Blocks:

Reported:	2017-12-11 21:22 UTC by Nikolaj Šujskij
Modified:	2017-12-12 19:37 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Full www-client/firefox-52.5.2 build.log (firefox-52.5.2_build.log.gz,88.71 KB, application/gzip) 2017-12-11 21:25 UTC, Nikolaj Šujskij	Details
emerge --info '=www-client/firefox-52.5.2::gentoo' (file_640770.txt,17.66 KB, text/plain) 2017-12-11 21:26 UTC, Nikolaj Šujskij	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nikolaj Šujskij 2017-12-11 21:22:59 UTC

% emerge -pqv '=www-client/firefox-52.5.2::gentoo'
[ebuild     U ] www-client/firefox-52.5.2 [52.5.0] USE="dbus gmp-autoupdate gtk2 hwaccel jemalloc startup-notification system-harfbuzz system-icu system-jpeg system-libvpx system-sqlite -bindist -custom-cflags -custom-optimization -debug -eme-free -hardened -jack (-neon) -pgo -pulseaudio (-rust) (-selinux) (-system-cairo) -system-libevent {-test} -wifi" L10N="ru sv -ach -af -an -ar -as -ast -az -bg -bn-BD -bn-IN -br -bs -ca -cak -cs -cy -da -de -dsb -el -en-GB -en-ZA -eo -es-AR -es-CL -es-ES -es-MX -et -eu -fa -ff -fi -fr -fy -ga -gd -gl -gn -gu -he -hi -hr -hsb -hu -hy -id -is -it -ja -ka -kab -kk -km -kn -ko -lij -lt -lv -mai -mk -ml -mr -ms -nb -nl -nn -or -pa -pl -pt-BR -pt-PT -rm -ro -si -sk -sl -son -sq -sr -ta -te -th -tr -uk -uz -vi -xh -zh-CN -zh-TW"

 -------
In file included from /var/tmp/portage/www-client/firefox-52.5.2/work/firefox-52.5.2esr/ff/gfx/thebes/Unified_cpp_gfx_
thebes0.cpp:65:0:
/var/tmp/portage/www-client/firefox-52.5.2/work/firefox-52.5.2esr/gfx/thebes/gfxFont.cpp:2625:29: error: ‘mozilla::gfx
::ShapedTextFlags’ has not been declared
                        gfx::ShapedTextFlags aFlags,
                             ^~~~~~~~~~~~~~~
/var/tmp/portage/www-client/firefox-52.5.2/work/firefox-52.5.2esr/gfx/thebes/gfxFont.cpp:2626:24: error: ‘RoundingFlag
s’ has not been declared
                        RoundingFlags aRounding,
                        ^~~~~~~~~~~~~
/var/tmp/portage/www-client/firefox-52.5.2/work/firefox-52.5.2esr/gfx/thebes/gfxFont.cpp:2618:1: error: template-id ‘G
etShapedWord<>’ for ‘gfxShapedWord* gfxFont::GetShapedWord(gfxFont::DrawTarget*, const uint8_t*, uint32_t, uint32_t, g
fxFont::Script, bool, int32_t, int, int, gfxTextPerfMetrics*)’ does not match any template declaration
 gfxFont::GetShapedWord(DrawTarget *aDrawTarget,
 ^~~~~~~
 -------

Comment 1 Nikolaj Šujskij 2017-12-11 21:25:35 UTC

Created attachment 509548 [details]
Full www-client/firefox-52.5.2 build.log

Comment 2 Nikolaj Šujskij 2017-12-11 21:26:28 UTC

Created attachment 509550 [details]
emerge --info '=www-client/firefox-52.5.2::gentoo'

Comment 3 Alexander Tsoy 2017-12-12 07:04:05 UTC

Builds fine without 2005_fix_pgo_build.patch.

Comment 4 Joakim Tjernlund 2017-12-12 12:32:50 UTC

I got the same build failure.
Grepping the FF src I cannot find the definition of ShapedTextFlags

Comment 5 Jory A. Pratt gentoo-dev

2017-12-12 13:49:58 UTC

commit f11302032225f773c67d4c4f6686dea491a12b0d
Author: Jory A. Pratt <anarchy@gentoo.org>
Date:   Tue Dec 12 07:46:09 2017 -0600

    www-client/firefox: drop pgo build fix bug #640770
    
    Package-Manager: Portage-2.3.18, Repoman-2.3.6

Comment 6 Thomas Deutschmann (RETIRED) gentoo-dev

2017-12-12 19:37:18 UTC

*** Bug 640826 has been marked as a duplicate of this bug. ***