Bug 639172 – binutils-config-5-r3.ebuild of prefix installs wrong (i.e. unpatched) binutils-config

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description hsk17 2017-11-29 14:11:11 UTC]

imho, there is a bug in the recently released binutils-config-5-r3.ebuild of prefix, if a rpath version of prefix is in use:
in src_prepare(), the binutils-config script gets patched to work in a rpath prefix. but in src_install() the unpatched version out of FILESDIR gets installed.
this results in producing binaries without a RUNPATH pointing to the prefix libraries; e.g., git, emerged in prefix, will not find it's libpcre2-8.so in prefix.

the first line of src_install() should be:
  newbin "${S}"/${PN} ${PN}

[Comment 1 Fabian Groffen 2017-11-29 14:36:29 UTC]

I pushed a fix, thanks

[Comment 2 hsk17 2017-11-29 14:45:23 UTC]

additionally, the provided ldwrapper.c produces strange failures:

  ld: failed to execute /PREFIX/usr/x86_64-pc-linux-gnu/binutils-bin/2.29XXXX: No such file or directory

where XXXX are some random(?) non-printable characters.

one of the recent changes to ldwrapper.c was the elimination of a malloc and using a fixed size buffer string instead.  increasing the respective #define ESIZ from 1024 to 2048 seems to fix the problem for me and for now, not sure if this is a final solution...

[Comment 3 Fabian Groffen 2017-11-29 15:13:15 UTC]

I'm a tool, the buf is returned, so it can't be from the stack.

[Comment 4 Fabian Groffen 2017-11-29 15:18:06 UTC]

Fix is pushed now