Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 63702 - dev-php/mod_php: Previous bug workaround no longer applicable and affects configuration
Summary: dev-php/mod_php: Previous bug workaround no longer applicable and affects con...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High minor (vote)
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-11 13:59 UTC by Torne Wuff
Modified: 2004-09-14 10:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Torne Wuff 2004-09-11 13:59:44 UTC
The workaround for bug #18445 seems no longer required; the issue has been fixed in Apache2 and PHP4 for some time. The workaround both interferes with legitimate use of If-Modified-Since in PHP, and requires mod_headers to be enabled in Apache which may otherwise be unneeded.

With an appropriate version dependency, this workaround could be removed from the mod_php config, saving end users from modifying the PHP configuration. ;)
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2004-09-12 00:06:04 UTC
Before I remove the workaround, could you provide upstream links that show it's properly fixed?
Comment 2 Torne Wuff 2004-09-12 05:30:44 UTC
The fix was two parts: first, Apache needed to provide an API for filter modules to use to tell the server when a 304 is required - this was fixed in 2.0.40 with this changelog entry:
  *) Add a filter_init parameter to the filter registration functions
     so that a filter can execute arbitrary code before the handlers
     are invoked.  This resolves a problem where mod_include requests
     would incorrectly return a 304.  [Justin Erenkrantz]
(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9673)

This fixed the issue for mod_include as well, which is where it was originally discovered by the Apache team. Once this change was made, PHP was updated to actually use this API. The bug on PHP's 'zilla (http://bugs.php.net/bug.php?id=17098) doesn't make this very clear, but it was fixed in PHP 4.3.2 with this changelog entry:
- Fixed bug #17098 (make Apache2 aware that PHP scripts should not be cached).
  (Ilia)

I've tested it on my installation using apache-2.0.50-r1 and mod_php-4.3.8, and the fix is definately functioning correctly for me, and both the Apache and PHP bugs have been closed on the respective 'zillas.

Hope that's all the information you need.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2004-09-14 10:09:18 UTC
In cvs now, not bumping revisions yet.