Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 636996 - media-plugins/gst-plugins-faac-1.12.3 : /.../gstfaac.c:493:7: error: faacEncConfiguration {aka struct faacEncConfiguration} has no member named allowMidside
Summary: media-plugins/gst-plugins-faac-1.12.3 : /.../gstfaac.c:493:7: error: faacEncC...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GStreamer package maintainers
URL: https://github.com/knik0/faac/issues/8
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-09 18:33 UTC by Toralf Förster
Modified: 2017-11-23 12:07 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,16.25 KB, text/plain)
2017-11-09 18:33 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,80.23 KB, text/plain)
2017-11-09 18:33 UTC, Toralf Förster
Details
environment (environment,110.67 KB, text/plain)
2017-11-09 18:33 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,12.15 KB, application/x-bzip)
2017-11-09 18:33 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,27.12 KB, application/x-bzip)
2017-11-09 18:33 UTC, Toralf Förster
Details
media-plugins:gst-plugins-faac-1.12.3:20171109-043652.log (media-plugins:gst-plugins-faac-1.12.3:20171109-043652.log,49.78 KB, text/plain)
2017-11-09 18:33 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,35.28 KB, application/x-bzip)
2017-11-09 18:33 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2017-11-09 18:33:30 UTC
/var/tmp/portage/media-plugins/gst-plugins-faac-1.12.3/work/gst-plugins-bad-1.12.3/ext/faac/gstfaac.c: In function ‘gst_faac_open_encoder’:
/var/tmp/portage/media-plugins/gst-plugins-faac-1.12.3/work/gst-plugins-bad-1.12.3/ext/faac/gstfaac.c:493:7: error: ‘faacEncConfiguration {aka struct faacEncConfiguration}’ has no member named ‘allowMidside’
   conf->allowMidside = faac->midside;
       ^~
make: *** [Makefile:910: libgstfaac_la-gstfaac.lo] Error 1

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-desktop-plasma_libressl_20171106-195719

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-6.4.0 *

Available Python interpreters, in order of preference:
  [1]   python3.4
  [2]   python3.6 (fallback)
  [3]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby22 (with Rubygems) *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.6.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

emerge -qpv media-plugins/gst-plugins-faac
[ebuild  N    ] media-plugins/gst-plugins-faac-1.12.3  ABI_X86="(64) -32 (-x32)"
Comment 1 Toralf Förster gentoo-dev 2017-11-09 18:33:33 UTC
Created attachment 503334 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2017-11-09 18:33:36 UTC
Created attachment 503336 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2017-11-09 18:33:39 UTC
Created attachment 503338 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2017-11-09 18:33:42 UTC
Created attachment 503340 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2017-11-09 18:33:45 UTC
Created attachment 503342 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2017-11-09 18:33:48 UTC
Created attachment 503344 [details]
media-plugins:gst-plugins-faac-1.12.3:20171109-043652.log
Comment 7 Toralf Förster gentoo-dev 2017-11-09 18:33:51 UTC
Created attachment 503346 [details]
temp.tbz2
Comment 8 Mart Raudsepp gentoo-dev 2017-11-13 11:23:47 UTC
FAAC_CFG_VERSION 105 is breaking API here, possibly also ABI.
CCing faac maintainers, just in case, at least for awareness.
Comment 9 Mart Raudsepp gentoo-dev 2017-11-13 11:25:56 UTC
include/faaccfg.h changed

    /* Allow mid/side coding */
    unsigned int allowMidside;

to

    /* Joint coding mode */
    unsigned int jointmode;

somewhere between version 1.29.8.3 and 1.29.9; this seems especially fun to happen in a micro version bump of faac.
Comment 10 G.Wolfe Woodbury 2017-11-18 14:53:00 UTC
possible workaround:

add
   ">=media-libs/faac-1.29.9"

to
   /etc/portage/package.mask

and re-emerge media-libs/faac
Comment 11 Mart Raudsepp gentoo-dev 2017-11-21 15:14:55 UTC
Please try with faac-1.29.9.2 once it hits your mirrors and report back if it's fine now with it
Comment 12 G.Wolfe Woodbury 2017-11-23 09:13:54 UTC
(In reply to Mart Raudsepp from comment #11)
> Please try with faac-1.29.9.2 once it hits your mirrors and report back if
> it's fine now with it

faac-1.29.9.2 does, indeed, fix this problem, and packages using this (e.g. transcode) work well.  The masking recommended in comment #10 is not necessary if you automatically use the higest versioned unmasked packages.
Comment 13 Mart Raudsepp gentoo-dev 2017-11-23 12:07:48 UTC
Thanks, this is fixed by faac-1.29.9.2 bump then (and faac-1.29.9 is gone from tree), which restored API compatibility via an union for allowMidside varname.