Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 635820 - x11-misc/dmenu - add savedconfig support
Summary: x11-misc/dmenu - add savedconfig support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-29 17:43 UTC by Hadrien Lacour
Modified: 2019-02-06 08:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dmenu-4.7.ebuild.patch (dmenu-4.7.ebuild.patch,727 bytes, patch)
2017-10-29 17:43 UTC, Hadrien Lacour
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hadrien Lacour 2017-10-29 17:43:22 UTC
Created attachment 500918 [details, diff]
dmenu-4.7.ebuild.patch

Hello,
I've just noticed that dmenu is the only suckless application not having savedconfig support, so here's a patch to do it. The patch is only for 4.7, but the added lines should be the same for 4.6. 9999 would need another patch basically doing sed -i 's#config.def.h#config.h#'.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2017-10-30 15:48:20 UTC
(In reply to Hadrien Lacour from comment #0)
> I've just noticed that dmenu is the only suckless application not having
> savedconfig support, so here's a patch to do it.

The 9999 ebuild has had savedconfig support for ages. Apparently I didn't get around to porting it to the non-live ebuilds.

> The patch is only for 4.7,
> but the added lines should be the same for 4.6.

Backporting to 4.6 is a rather strange concept when 4.7 is around already.

> 9999 would need another
> patch basically doing sed -i 's#config.def.h#config.h#'.

Have you looked at the 9999 ebuild?
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2017-10-30 15:53:13 UTC
Fixed in 4.7-r1. Thanks for the patch.
Comment 3 Hadrien Lacour 2017-10-30 16:37:46 UTC
Thanks for the fast change. I've seen the 9999 ebuild, and what I want to say is that as far as I know, config.def.h is the default config, config.h is the user defined one (all their software use that scheme).
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2017-10-31 05:01:35 UTC
(In reply to Hadrien Lacour from comment #3)
> as far as I know, config.def.h is the default config, config.h
> is the user defined one (all their software use that scheme).

That wasn't obvious. Fixed now.