Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 63563 - Write blacklisted dirs into prelink.conf
Summary: Write blacklisted dirs into prelink.conf
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 63462 67467
  Show dependency tree
 
Reported: 2004-09-10 09:25 UTC by Stefan Jones (RETIRED)
Modified: 2004-10-22 08:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
portage-prelink-blacklist.patch (portage-prelink-blacklist.patch,332 bytes, patch)
2004-09-10 09:29 UTC, Stefan Jones (RETIRED)
Details | Diff
env-update.prelink.patch (env-update.prelink.patch,436 bytes, patch)
2004-10-14 10:58 UTC, Stefan Jones (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Jones (RETIRED) gentoo-dev 2004-09-10 09:25:54 UTC
This patch makes dirs in PRELINK_PATH_MASK env variable blacklisted.
Useful for packages like wine and valgrind which break if prelinked.

Reproducible: Always
Steps to Reproduce:
Comment 1 Stefan Jones (RETIRED) gentoo-dev 2004-09-10 09:29:27 UTC
Created attachment 39327 [details, diff]
portage-prelink-blacklist.patch
Comment 2 Stefan Jones (RETIRED) gentoo-dev 2004-09-16 10:31:15 UTC
For your information:

Same patch works against portage-2.0.51_rc1 with just 100line offset. Can remake the patch if required but it is not needed.
Comment 3 Nicholas Jones (RETIRED) gentoo-dev 2004-09-21 18:10:34 UTC
Have we had testing on this?

How are old versions handled here?

Does it break anything during normal operations, or does this only
affect system prelinking operations?

Comment 4 Stefan Jones (RETIRED) gentoo-dev 2004-09-21 21:50:19 UTC
> Have we had testing on this?

I have only tested it locally, but it is a small effect patch

> How are old versions handled here?

Old versions of prelink did not set PRELINK_PATH_MASK in the portage distro automatically so will not generate the new lines.

If it does then prelink will just print a minor warning before continuing about unrecognised line.

But only ^really^ old versions of prelink are effected, all those in portage support the new option. (and they have been there for months)

> Does it break anything during normal operations, or does this only
affect system prelinking operations?

Only effects the prelink.conf file, adding a few lines ^only^ if PRELINK_PATH_MASK is set. ( -b <dir> lines to be exact )
This code is only triggered when env-update stuff runs and writes the prelink.conf file.
Comment 5 Stefan Jones (RETIRED) gentoo-dev 2004-10-14 10:58:19 UTC
Created attachment 41815 [details, diff]
env-update.prelink.patch

Missed env-update.sh - not sure when it is used but needs updating.
Patch attached, please commit - as harmless as the last patch!
Comment 6 Nicholas Jones (RETIRED) gentoo-dev 2004-10-22 08:47:58 UTC
Bug has been fixed and released in stable portages on or before 2.0.51-r2