Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 634524 - Git hook: "Fixes:" in commit message triggers a warning
Summary: Git hook: "Fixes:" in commit message triggers a warning
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Git (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Infrastructure
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-17 09:58 UTC by Ulrich Müller
Modified: 2022-06-27 17:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2017-10-17 09:58:16 UTC
When pushing a series of commits containing this:
https://gitweb.gentoo.org/proj/pms.git/commit/?id=3821ea48319116532d72cf6\
5f08a8cca9428056c
I get the following warning:

$ git push
Counting objects: 10, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (10/10), done.
Writing objects: 100% (10/10), 1.15 KiB | 1.15 MiB/s, done.
Total 10 (delta 7), reused 0 (delta 0)
remote: WARNING: invalid/unsupported bug ref: ef961a6f9b91fc0e4ff41da84a3f92888c13d116
To git+ssh://git.gentoo.org/proj/pms.git
   04e3e07..36ac295  master -> master

According to the GLEP 66 draft, "Fixes: <commit-id>" should be legal.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-11-30 11:20:15 UTC
Should be fixed now.  Please close when someone confirms.
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2019-11-30 15:07:49 UTC
I just pushed https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80ca6a7673eb880effda57e878fe5cb4f8ad5018 and got

> $ git push
> Enumerating objects: 9, done.
> Counting objects: 100% (9/9), done.
> Delta compression using up to 4 threads
> Compressing objects: 100% (5/5), done.
> Writing objects: 100% (5/5), 1.01 KiB | 1.01 MiB/s, done.
> Total 5 (delta 4), reused 0 (delta 0)
> remote: WARNING: 'Fixes' tag should reference commit id, not: https://bugs.gentoo.org/701560
> remote:  * Info: Using [Gentoo] (https://bugs.gentoo.org/xmlrpc.cgi)
> remote:  * Info: Modified the following fields in bug 701560
> remote:  * Info: status      : removed CONFIRMED
> remote:  * Info: status      : added RESOLVED
> remote:  * Info: resolution  : removed
> remote:  * Info: resolution  : added FIXED
> remote: To github.com:gentoo/gentoo.git
> remote:    28cb4fcc47c..80ca6a7673e  master -> master
> To git+ssh://git.gentoo.org/repo/gentoo.git
>    28cb4fcc47c3..80ca6a7673eb  master -> master
> 

Will try later with commit id.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2019-12-18 07:36:11 UTC
mgorny:
Please permit URLs in the Fixes footer.

They make it possible to cleanly link issues in external trackers, including GitHub.

It's not semantically the same as "Closes:" which does permit a URL. Fixes states that the linked issue is considered closed AND fixed, not just closed.
Comment 4 Ulrich Müller gentoo-dev 2022-06-27 17:01:17 UTC
AFAICS this is fixed since some time.