Created attachment 498830 [details] build log x86_64-pc-linux-gnu-gcc --pedantic -Wall -std=c99 -march=native -O2 -msse3 -pipe -fno-unwind-tables -fno-asynchronous-unwind-tables -Wl,-O1 -Wl,--as-needed -o hh hashset.o hstr_curses.o hstr_history.o hstr_utils.o hstr_favorites.o hstr_blacklist.o hstr_regexp.o radixsort.o hstr.o -lreadline -lm -lncursesw /usr/lib/gcc/x86_64-pc-linux-gnu/6.4.0/../../../../x86_64-pc-linux-gnu/bin/ld: hstr_curses.o: undefined reference to symbol 'keypad' /lib64/libtinfo.so.6: error adding symbols: DSO missing from command line emerge --info is attached
Created attachment 498832 [details] emerge --info
Should be fixed in 1.23. I am checking if 1.22-r1 is affected.
ebuild hstr-1.22-r1.ebuild manifest clean test install Appending /home/jer/git/gentoo to PORTDIR_OVERLAY... Forcing test. >>> Creating Manifest for /home/jer/git/gentoo/app-shells/hstr >>> Downloading 'https://github.com/dvorka/hstr/archive/1.22.tar.gz' --2017-10-16 13:49:08-- https://github.com/dvorka/hstr/archive/1.22.tar.gz Resolving github.com (github.com)... 192.30.253.113, 192.30.253.112 Connecting to github.com (github.com)|192.30.253.113|:443... connected. HTTP request sent, awaiting response... 302 Found Location: https://codeload.github.com/dvorka/hstr/tar.gz/1.22 [following] --2017-10-16 13:49:08-- https://codeload.github.com/dvorka/hstr/tar.gz/1.22 Resolving codeload.github.com (codeload.github.com)... 192.30.253.121, 192.30.253.120 Connecting to codeload.github.com (codeload.github.com)|192.30.253.121|:443... connected. HTTP request sent, awaiting response... 200 OK Length: unspecified [application/x-gzip] Saving to: ‘/aches/gentoo/distfiles/hstr-1.22.tar.gz’ /aches/gentoo/distfiles/hstr-1.22.tar.g [ <=> ] 45.40K 207KB/s in 0.2s 2017-10-16 13:49:09 (207 KB/s) - ‘/aches/gentoo/distfiles/hstr-1.22.tar.gz’ saved [46487] !!! Fetched file: hstr-1.22.tar.gz VERIFY FAILED! !!! Reason: Failed on SHA256 verification !!! Got: 384fee04e4c80a1964dcf443131c1da4a20dd474fb48132a51d3de0a946ba996 !!! Expected: c4995e7041dc66e2118f83bd4c6c7f4cff5b4c493ca28bd7e4aef76edeff71ba Refetching... File renamed to '/aches/gentoo/distfiles/hstr-1.22.tar.gz._checksum_failure_.xxy3ex3n' !!! Couldn't download 'hstr-1.22.tar.gz'. Aborting. Something changed in the Matrix.
OK, upstream has problems writing a configure.ac that works. In 1.22 PKG_CHECK_MODULES is properly used and automagically discovers libtinfo, but in 1.23 AC_CHECK_LIB is preferred, citing problems that arise when pkg-config is not installed.
Looks like the RDEPEND on ncurses is missing [tinfo] in this case too, otherwise libtinfo.so isn't installed.
(In reply to Dan Goodliffe from comment #5) > Looks like the RDEPEND on ncurses is missing [tinfo] in this case too, Why would you want to do that? > otherwise libtinfo.so isn't installed. Whether it is installed/needed should be discovered in configure: 1) We have ncurses? Yes. 2) Does ncurses provide keypad? 2a) No? Does tinfo provide keypad? Use tinfo... 2b) No? Goto fail.
Because without USE=tinfo on ncurses, configure fails with: checking for keypad in -ltinfo... no configure: error: Could not find tinfo library Which doesn't feel right.
(In reply to Dan Goodliffe from comment #7) > Because without USE=tinfo on ncurses, configure fails with: > > checking for keypad in -ltinfo... no > configure: error: Could not find tinfo library > > Which doesn't feel right. Ah yes, I should have substituted AC_SEARCH_LIBS for AC_CHECK_LIB. But again, upstream is confused and should not have used that weird twist.
commit 187aae663128101c709b9262f8032226e714eca9 Author: Jeroen Roovers <jer@gentoo.org> Date: Tue Oct 17 00:28:42 2017 +0200 app-shells/hstr: Use AC_SEARCH_LIBS not AC_CHECK_LIB (bug #634428). Package-Manager: Portage-2.3.11, Repoman-2.3.3 commit 67ad15bb7a3095df22fb33bb6891cfa78a856bea Author: Jeroen Roovers <jer@gentoo.org> Date: Mon Oct 16 13:46:37 2017 +0200 app-shells/hstr: Fix building against sys-libs/ncurses[tinfo] (bug #634428). Package-Manager: Portage-2.3.11, Repoman-2.3.3
