Created attachment 498398 [details] build.log I have this output when upgrading nvidia. ERROR: x11-drivers/nvidia-drivers-387.12::gentoo failed (prepare phase): * patch -p1 failed with /var/tmp/portage/x11-drivers/nvidia-drivers-387.12/files/nvidia-drivers-387.12-linker.patch * * Call stack: * ebuild.sh, line 124: Called src_prepare * environment, line 5020: Called default * phase-functions.sh, line 853: Called default_src_prepare * phase-functions.sh, line 918: Called __eapi6_src_prepare * environment, line 386: Called eapply '/var/tmp/portage/x11-drivers/nvidia-drivers-387.12/files/nvidia-drivers-387.12-linker.patch' * environment, line 1261: Called _eapply_patch '/var/tmp/portage/x11-drivers/nvidia-drivers-387.12/files/nvidia-drivers-387.12-linker.patch' * environment, line 1199: Called __helpers_die 'patch -p1 failed with /var/tmp/portage/x11-drivers/nvidia-drivers-387.12/files/nvidia-drivers-387.12-linker.patch' * isolated-functions.sh, line 117: Called die * The specific snippet of code: * die "$@" emerge --info Portage 2.3.11 (python 3.6.3-final-0, default/linux/amd64/13.0/no-multilib, gcc-7.2.0, glibc-2.25-r7, 4.12.14-ck x86_64) ================================================================= System uname: Linux-4.12.14-ck-x86_64-Intel-R-_Core-TM-_i5-3570K_CPU_@_3.40GHz-with-gentoo-2.4.1 KiB Mem: 32897260 total, 11789252 free KiB Swap: 0 total, 0 free Timestamp of repository gentoo: Wed, 11 Oct 2017 09:24:13 +0000 Head commit of repository gentoo: ac87e4c98c674d21e10f041ffb8ca33f8f4a35f4 sh bash 4.4_p12 ld GNU ld (Gentoo 2.29.1 p1.0) 2.29.1 ccache version 3.3.4 [disabled] app-shells/bash: 4.4_p12::gentoo dev-lang/perl: 5.26.1::gentoo dev-lang/python: 2.7.14::gentoo, 3.6.3::gentoo dev-util/ccache: 3.3.4-r1::gentoo dev-util/cmake: 3.9.4::gentoo dev-util/pkgconfig: 0.29.2::gentoo sys-apps/baselayout: 2.4.1-r2::gentoo sys-apps/openrc: 0.32.1::gentoo sys-apps/sandbox: 2.12::gentoo sys-devel/autoconf: 2.13::gentoo, 2.69-r4::gentoo sys-devel/automake: 1.15.1-r1::gentoo sys-devel/binutils: 2.29.1::gentoo sys-devel/gcc: 6.4.0::gentoo, 7.2.0::gentoo sys-devel/gcc-config: 1.9.0::gentoo sys-devel/libtool: 2.4.6-r4::gentoo sys-devel/make: 4.2.1-r1::gentoo sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers) sys-libs/glibc: 2.25-r7::gentoo Repositories: gentoo location: /usr/portage sync-type: git sync-uri: git://github.com/gentoo-mirror/gentoo.git priority: -1000 fhede location: /usr/local/portage masters: gentoo frabjous location: /var/lib/layman/frabjous masters: gentoo priority: 50 xfce-dev location: /var/lib/layman/xfce-dev masters: gentoo priority: 50 ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=ivybridge -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-march=ivybridge -O2 -pipe" DISTDIR="/usr/portage/distfiles" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="ftp://trumpetti.atm.tut.fi/gentoo/ http://trumpetti.atm.tut.fi/gentoo/ ftp://mirror.mdfnet.se/gentoo/" INSTALL_MASK="COPYING* /etc/systemd /lib/systemd /usr/lib/systemd" LANG="en_US.utf8" LC_ALL="en_US.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j5" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X acl alsa amd64 berkdb bzip2 cli consolekit cracklib crypt cxx dbus dri dvdr fortran freetype gdbm gif gtk3 iconv icu ipv6 jpeg lock modules ncurses nls nptl openmp pam pcre png policykit raw readline seccomp session ssl svg tcpd thunar truetype udev unicode xattr xscreensaver zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" L10N="sv" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="sv_SE" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby22" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Created attachment 498400 [details, diff] Proposed patch I can confirm this. The patch is unconditionally applied too early to files out of the nvidia-settings tarball.
Hmm. Did I just add jer@gentoo.org to CC? If so, unexpected, but welcome. jer, please have a look at my patch (keep an empty 'PATCHES=( ... )' if you prefer, I just made the patch as "clean" as could be ;) And sorry about extra mails notifying just about adding jer as CC. And I hope jer is still the maintainer.
Comment on attachment 498400 [details, diff] Proposed patch eapply is the new epatch!
Jer, 1. thanks for fixing the issue, but 2. the solution you chose _really bad_ in so far as you chose to a) you _did_ apply my patch like so: curl https://634026.bugs.gentoo.org/attachment.cgi?id=498400 | sed 's/epatch/eapply/' | patch -p1 as I could find by digging in the git-repo... b) delete my patch here, and closed/fixed the bug without any further mention of _what and why_ you actually did. Only by digging into the git version of the ebuild I found that you actually did use my patch as in a). Anyone else would have no idea of what and how the bug was fixed, if at all. I call that bad style technically and personally. Would it have been that much harder to just say: "patch works, replacing 'epatch' with 'eapply' though. Closing as fixed / resolved." and leave the rest untouched? That'd be traceable, understandable and just generally much more friendly to those that submit bugs and/or propose patches or whatever... And DO NOT DELETE STUFF from other people! Fixing mime-types ok, but deleting? No!
Comment on attachment 498400 [details, diff] Proposed patch patch _is_ applied, with the "cosmetic" 's/epatch/eapply/' though.
Comment on attachment 498400 [details, diff] Proposed patch (In reply to David Haller from comment #4) > And DO NOT DELETE STUFF from other people! Fixing mime-types ok, but > deleting? No! I didn't delete anything. "Obsolete" means it doesn't need applying any longer.
