Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 633706 - dev-util/rustfmt could depend on virtual/rust instead of dev-lang/rust
Summary: dev-util/rustfmt could depend on virtual/rust instead of dev-lang/rust
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Rust Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-07 14:21 UTC by EoD
Modified: 2018-11-15 10:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description EoD 2017-10-07 14:21:25 UTC
Currently, dev-util/rustfmt pulls in dev-lang/rust and causes long compile times, while it should work as well with dev-lang/rust-bin. Hence virtual/rust seems to be a better choice.

I created some rust code and applied rustfmt successful without dev-lang/rust installed.
Comment 1 EoD 2018-06-02 13:32:14 UTC
Is there any reason to object against this change?
Comment 2 Dirkjan Ochtman (RETIRED) gentoo-dev 2018-06-02 14:12:36 UTC
It makes some amount of sense. On the other hand, on rustup setups, a rust toolchain now optionally includes rustfmt as a separate component, so I would prefer in the direction of pulling that in as part of the rust/rust-bin ebuilds.
Comment 3 gibix 2018-06-05 17:47:38 UTC
The rustup way to handle this is that every tool match a toolchain version, at least if you install them with rustup component. This decision should propagate to all the non-cargo rust components (clippy, rls, analysis, etc).
Comment 4 Dirkjan Ochtman (RETIRED) gentoo-dev 2018-11-15 10:47:16 UTC
This has been fixed, since the cargo eclass now pulls in virtual/rust.