Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 633380 - net-analyzer/netdata-1.8.0 : installs into paths that should be created at runtime
Summary: net-analyzer/netdata-1.8.0 : installs into paths that should be created at ru...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-03 14:33 UTC by Toralf Förster
Modified: 2017-10-04 13:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2017-10-03 14:33:52 UTC
QA: other
QA Notice: This ebuild installs into paths that should be created at runtime.
 To fix, simply do not install into these directories.  Instead, your package
 should create dirs on the fly at runtime as needed via init scripts/etc...

  var/cache
  var/cache/netdata
  var/cache/netdata/.keep
QA Notice: shell script appears to use non-POSIX feature(s):
   possible bashism in /etc/init.d/netdata line 41 (alternative test command ([[ foo ]] should be [ foo ])):
   	if [[ ! -f /etc/netdata/netdata.conf ]]; then
   possible bashism in /etc/init.d/netdata line 46 (alternative test command ([[ foo ]] should be [ foo ])):
   		if [[ $ret -eq 0 && -s /etc/netdata/netdata.conf.new ]]; then
   possible bashism in /etc/init.d/netdata line 47 (brace expansion):
   			mv /etc/netdata/netdata.conf{.new,}
   possible bashism in /etc/init.d/netdata line 60 (alternative test command ([[ foo ]] should be [ foo ])):
   	while [[ -f "${pidfile}" ]]; do
   possible bashism in /etc/init.d/netdata line 61 (alternative test command ([[ foo ]] should be [ foo ])):
   		if [[ $count -gt ${NETDATA_WAIT_EXIT_TIMEOUT} ]]; then
   possible bashism in /etc/init.d/netdata line 66 ('$[' should be '$(('):
   		count=$[count + 1]
   possible bashism in /etc/init.d/netdata line 73 (alternative test command ([[ foo ]] should be [ foo ])):
   	if [[ $sigkill -eq 1 && -f "${pidfile}" ]]; then

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 13.0-systemd_20170910-171402

  -------------------------------------------------------------------
Comment 1 Craig Andrews gentoo-dev 2017-10-03 14:53:19 UTC
Pull request to upstream to remove bashisms: https://github.com/firehol/netdata/pull/2836