632320 – net-analyzer/munin-2.0.33: ./getversion failes if inside git i.e. /.git

Bug 632320 - net-analyzer/munin-2.0.33: ./getversion failes if inside git i.e. /.git

Summary: net-analyzer/munin-2.0.33: ./getversion failes if inside git i.e. /.git

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Sysadmin Bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2017-09-29 00:05 UTC by Michael Weber (RETIRED)
Modified:	2017-10-15 06:41 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
don't generate version string accessing git in releases. (global-git.patch,327 bytes, patch) 2017-09-29 00:05 UTC, Michael Weber (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Weber (RETIRED) gentoo-dev

2017-09-29 00:05:54 UTC

Created attachment 496988 [details, diff]
don't generate version string accessing git in releases.

the RELEASE=$(shell ) which calls ./getversion evaluates empty if there is an .git above ${WORKDIR}, i.e. a /.git.

The resulting calls to pod2man --release= fails with an missing argument error.

Work around: move /.git to /.git_ .

Fix: don't access outside ${WORKDIR}.

Comment 1 Michael Weber (RETIRED) gentoo-dev

2017-09-29 02:06:20 UTC

see bug 632318 for emerge --info and build.log

Comment 2 Hans de Graaff gentoo-dev

2017-10-15 06:41:39 UTC

It seems to me that this setup will cause more issues than just this bug, but I have no problem applying the patch since we can be sure that we won't work with a git repo in this case.

Added to munin-2.0.33-r1