Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 630260 - =sys-firmware/broadcom-bt-firmware-12.0.1.1011_p1 - Broadcom Bluethooth firmware
Summary: =sys-firmware/broadcom-bt-firmware-12.0.1.1011_p1 - Broadcom Bluethooth firmware
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Default Assignee for New Packages
URL: https://github.com/winterheart/broadc...
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2017-09-07 16:45 UTC by Jan Henke
Modified: 2018-02-18 08:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed ebuild (broadcom-bt-firmware-12.0.1.1011_p1.ebuild,474 bytes, text/plain)
2017-09-07 16:45 UTC, Jan Henke
Details
Proposed ebuild (v2) (broadcom-bt-firmware-12.0.1.1011_p1.ebuild,498 bytes, text/plain)
2017-09-10 20:16 UTC, Jan Henke
Details
Proposed ebuild (v3) (broadcom-bt-firmware-12.0.1.1011_p1.ebuild,535 bytes, text/plain)
2017-09-17 20:01 UTC, Jan Henke
Details
Alternative ebuild for broadcom firmwaree (broadcom-bt-firmware-12.0.1.1011.ebuild,1.10 KB, text/plain)
2018-02-18 08:00 UTC, faminebadger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Henke 2017-09-07 16:45:18 UTC
Created attachment 493060 [details]
Proposed ebuild

Broadcom devices need two separate firmware files. net-wireless/broadcom-sta provides the kernel driver and firmware for the WLAN (WiFi) part of the device. For the bluetooth part to work, but an in-tree kernel driver and a firmware file is needed.

This ebuild builds on the work done in https://github.com/winterheart/broadcom-bt-firmware for providing the necessary firmware files. Without these files the bluetooth device is visible, but fails to pair with other devices and cannot establish a connection.

I would volunteer to maintain this ebuild via proxy-maintainers. Therefore I am looking for a review of the ebuild and if acceptable for it to be added to the Gentoo tree.
Comment 1 Jonas Stein gentoo-dev 2017-09-07 21:52:28 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman https://wiki.gentoo.org/wiki/Repoman
* fix license: see /usr/portage/licenses/
* please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)

DESCRIPTION=
should contain the supported chipsets or exact devices...

How often does upstream update this driver?

What is the package name in other distributions? 
Can you link it in http://repology.org/ for example?
Comment 2 Jan Henke 2017-09-10 20:16:51 UTC
Created attachment 493794 [details]
Proposed ebuild (v2)

Attached is an updated ebuild, which should fix the QA issues. Updates occur irregular, but are rare.
Comment 3 Jan Henke 2017-09-17 20:01:56 UTC
Created attachment 495114 [details]
Proposed ebuild (v3)

Based on TitanOfOld feedback on IRC in #gentoo-proxy-maint, attached is v3 of the proposed ebuild.
Comment 4 Jan Henke 2018-01-08 17:15:48 UTC
The upstream repository is very vague about the legal side of thinks. So an in-tree ebuild does not seem to be a good idea right now.
I will mark this bug as RESOLVED/WONTFIX, no more action needed, just a bit of house keeping.
Comment 5 faminebadger 2018-02-18 08:00:20 UTC
Created attachment 519920 [details]
Alternative ebuild for broadcom firmwaree

I also independently wrote an ebuild for this firmware, and was just about to submit it as a proposed new ebuild - but bugzilla pointed me here.

I've attached mine, as it does a little bit more than the previous one here (namely uses savedconfig to just install the firmware you care about, which for most people is only a single file).

Since broadcom bluetooth is useless without the firmware file, I disagree strongly with the decision not to keep an ebuild like this one in the tree - it can be quite hard for a normal user to find the information on what to do to get this file.

Furthermore, "The upstream repository is very vague about the legal side of thinks (sic)" seems an odd comment - the git readme is quite clear that broadcom's licence applies, which they link too - so what is the lack of clarity referred to here?

Given broadcom publish the files publicly to the windows update database, with the same licence as cited by the git source, I don't see any problems.