Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 629802 - net-libs/libtorrent-rasterbar-1.0.11: fails to build with boost-1.65
Summary: net-libs/libtorrent-rasterbar-1.0.11: fails to build with boost-1.65
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Markos Chandras (RETIRED)
URL: https://github.com/arvidn/libtorrent/...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-09-03 18:45 UTC by Holger Hoffstätte
Modified: 2017-09-05 08:04 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoffstätte 2017-09-03 18:45:19 UTC
When rebuilding with boost-1.65 libtorrent-rasterbar-1.0.11 fails with compile error in $URL as it tries to include private headers that are now gone. This affects at least all versions in the 1.0.x series.


Reproducible: Always

Steps to Reproduce:
1. Update to boost-1.65
2. emerge libtorrent-rasterbar-1.0.11
3. fail :(
Actual Results:  
libtorrent-rasterbar-1.0.11 fails to build.

Expected Results:  
libtorrent-rasterbar-1.0.11 should build successfully.

The problem can be easily fixed by including the patch from:

https://github.com/arvidn/libtorrent/pull/2146/commits/4455db936963aa0e7a8aad7c3b43790f7491b299

which replaces inclusion of the private headers with the official way of doing things in boost.

I added the patch in my overlay and libtorrent-rasterbar-1.0.11 now builds & works fine (tested with deluge). Ebuilds for all 1.0.x versions will have the same problem; 1.1.x it will depend on the release date.
Comment 1 Holger Hoffstätte 2017-09-03 18:49:27 UTC
Just saw that the upstream fix was committed for 1.1-rc, so it should be in all 1.1.x releases.
Comment 2 Nick Wallingford 2017-09-03 23:30:28 UTC
(In reply to Holger Hoffstätte from comment #1)
> Just saw that the upstream fix was committed for 1.1-rc, so it should be in
> all 1.1.x releases.

Unfortunately, net-p2p/deluge depends strictly on <net-libs/libtorrent-rasterbar-1.1. The fix will need to be backported to 1.0.*.
Comment 3 Holger Hoffstätte 2017-09-04 09:16:26 UTC
(In reply to Nick Wallingford from comment #2)
> (In reply to Holger Hoffstätte from comment #1)
> > Just saw that the upstream fix was committed for 1.1-rc, so it should be in
> > all 1.1.x releases.
> 
> Unfortunately, net-p2p/deluge depends strictly on
> <net-libs/libtorrent-rasterbar-1.1. The fix will need to be backported to
> 1.0.*.

Huh? There's nothing to backport, it applies cleanly.
As I wrote above I tested all this with 1.0.11 already.
Comment 4 Karl Lindén 2017-09-04 18:50:17 UTC
I ran in to this when updating today.

PR at https://github.com/gentoo/gentoo/pull/5615
Comment 5 Larry the Git Cow gentoo-dev 2017-09-05 08:04:42 UTC
Bug has been closed via the following commit:
    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=58d30be41daa34f565ab38ab7d92c64fe92acf5d

    commit 58d30be41daa34f565ab38ab7d92c64fe92acf5d
Author:     Karl Linden <karl.j.linden@gmail.com>
AuthorDate: 2017-09-04 18:45:35 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2017-09-05 08:04:30 +0000

    net-libs/libtorrent-rasterbar: fix compilation with boost-1.65.0
    
    * Apply upstream patch from commit 7eb3cf5.
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=629802
    Package-Manager: Portage-2.3.8, Repoman-2.3.3
    Closes: https://github.com/gentoo/gentoo/pull/5615

 ...rent-rasterbar-1.0.11-boost-config-header.patch |  31 ++++++
 .../libtorrent-rasterbar-1.0.11-r1.ebuild          | 117 +++++++++++++++++++++
 2 files changed, 148 insertions(+)