The original Makefile was generated with qt4, so if you decide to leave it this way, please allow both qt4 and qt5 to fulfill the dependency. Alternatively, please consider removing it altogether and doing something like this in src_prepare (test build went fine for me): sed -i "s^/usr/local/lib/^/usr/$(get_libdir)/^g; s^/usr/local/^/usr/^g" Makefile
The bundled Makefile includes a number of other QA violations, not just libdir - for example it ignores $CC, $CFLAGS, $LDFLAGS and pre-strips files. We moved from regenerating it with Qt 4 to Qt 5 in the last version bump because Qt 4 is dead and we're working to remove it from the tree.
Michael, Thanks a lot for your prompt attention, much appreciated! I didn't expect qt4 qmake to generate such a broken Makefile, so I didn't even look in that direction (assuming qt4 and qt5 qmakes are about equivalent). But if it is ignoring CC, CFLAGS and LDFLAGS that's indeed unacceptable. I can imagine you bundling a fixed Makefile as a patch but I also understand how much of a maintenance burden that might add for relatively little gain. When building OpenSCAD I was surprised to see both qt4 and qt5 were required and so assumed something was wrong with it. Probably the correct solution would be to build OpenSCAD with qt5 instead (the upstream supports qt5 officially)?
Just to clarify, it's not Qt4 itself that's generating a broken Makefile. qmake in general causes endless grief for a source-based distribution, and we were regenerating it when we were calling Qt 4 too. As you point out the only revdep of opencsg is openscad, so you're right it doesn't make much sense for one to pull Qt 4 and one Qt 5. I have poked openscad upstream to see if there's plans for a release (which should support Qt 5). Otherwise, I guess we may as well switch opencsg back to Qt 4.
Got it, thank you, I had no idea qmake-generated makefiles are so crappy. Please close this bug as you see fit.
I've taken over opencsg and attempting to bump the package to fix all open bugs....I do note that we don't seem to have qt4 even in the tree now, so given that we have only qt5 to work with....do we need to patch anything in the upstream Makefile or are we all good?
Hey Matthew, If qt4 is gone from the tree then it means OpenSCAD is now using qt5 and so there's no reason to not use qt5 for opencsg as well. The makefile doesn't need any patching if it's regenerated with qmake on user's system. Please feel free to close the bug.
