Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 62964 - [new ebuild] gwebcache
Summary: [new ebuild] gwebcache
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Web Application Packages Maintainers
URL: http://www.gnucleus.com/gwebcache/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-05 20:11 UTC by Jon Hood (RETIRED)
Modified: 2004-09-06 18:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-p2p/gwebcache-1.0.0.ebuild (gwebcache-1.0.0.ebuild,1.34 KB, text/plain)
2004-09-05 20:12 UTC, Jon Hood (RETIRED)
Details
/files/reconfig (reconfig,202 bytes, text/plain)
2004-09-05 20:12 UTC, Jon Hood (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Hood (RETIRED) gentoo-dev 2004-09-05 20:11:09 UTC
This is my first attempt at a webapp.eclass ebuild and I wanted to get the herd's approval before committing it to portage.

Another reserve I have is that only people who have the bandwidth should install this package; should something that could potentially bring home servers to their knees be placed into portage (even with all the warnings)?
Comment 1 Jon Hood (RETIRED) gentoo-dev 2004-09-05 20:12:05 UTC
Created attachment 39021 [details]
net-p2p/gwebcache-1.0.0.ebuild
Comment 2 Jon Hood (RETIRED) gentoo-dev 2004-09-05 20:12:41 UTC
Created attachment 39022 [details]
/files/reconfig
Comment 3 Renat Lumpau (RETIRED) gentoo-dev 2004-09-06 00:25:58 UTC
Jon,

Thanks for showing it to us first. Looks good, here are some comments as you requested:

- I'd ${P} in SRC_URI :)
- don't use vhosts in IUSE, the eclass will handle it for you
- I'd give a more informative warning in preinst. Also, don't sleep unless you want Mr_Bones_ to hunt you down
- don't rm things in src_install, same reason :). just do a more selective cp -R
- I'd drop pkg_postinst and move the instructions into webapp postinstall instructions (see man webapp.eclass)
- the reconfig hook should clean up after itself, so throw in a quick rm when called with "clean".

Looks good otherwise, great work!
Comment 4 Renat Lumpau (RETIRED) gentoo-dev 2004-09-06 00:27:28 UTC
Also, I'd chmod +x in the ebuild as opposed to the reconfig hook.
Comment 5 Jon Hood (RETIRED) gentoo-dev 2004-09-06 18:08:13 UTC
I've decided not to add this to portage- I think there's a faster gnutella web caching client anyways.