Bug 629148 – sys-apps/portage-9999 - 50gnome2-utils QA check produces many false positives

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Coacher 2017-08-28 07:44:07 UTC]

Created attachment 490952 [details]
emerge --info

Hello.

Portage constantly shows the QA warning as seen in QA.log

These cursors belong to x11-themes/neutral-xcursors and kde-plasma/oxygen, which both call gnome2_icon_cache_update().

portage-9999 @ 4dc6f7494

[Comment 1 Coacher 2017-08-28 07:44:29 UTC]

Created attachment 490954 [details]
QA.log

[Comment 2 Coacher 2017-08-28 07:45:41 UTC]

CC'ing mgorny as the author of these checks.

[Comment 3 Coacher 2017-08-28 08:30:59 UTC]

After re-emerging x11-themes/neutral-xcursors, which has

pkg_preinst() {
	gnome2_icon_savelist
}

pkg_postinst() {
	gnome2_icon_cache_update
}

pkg_postrm() {
	gnome2_icon_cache_update
}

in ebuild, QA warning re icons provided by this package still stays.

[Comment 4 Michał Górny 2017-08-28 18:10:27 UTC]

Looks like gtk-update-icon-cache is not generating cache for those. @gnome, any clue? Might it be because there are only cursors included there?

[Comment 5 Gilles Dartiguelongue (RETIRED) 2017-08-28 22:26:42 UTC]

Afaik, the index.theme should have a Directories entry listing directories of theme and a dedicated section per directory with the size of the icon set. However it seems that cursor themes are actually meant to go to /usr/share/cursors/xorg-x11

[Comment 6 Michał Górny 2017-08-29 07:55:57 UTC]

I've looked into the sources and it seems that gtk-icon-cache-update doesn't care about the index.theme beyond whether it exists or not. However, it seems to care only about *.{png,svg,xpm,icon} files. I'm going to update the check to match that.

However, this leaves the question whether those cursors are installed in the correct location open.

[Comment 7 Gilles Dartiguelongue (RETIRED) 2017-08-30 06:23:28 UTC]

Pull request was merged. Thanks for reporting.