Bug 629146 – Test errors with Python 3.7 due to non-string value in defaults passed to configparser.ConfigParser

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Arfrever Frehtes Taifersar Arahesis 2017-08-28 06:08:42 UTC]

Since:
  https://bugs.python.org/issue23835
  https://github.com/python/cpython/commit/44e6ad87340d50f48daf53b6a61138377d0d0d10

147 of 272 tests of Portage result in errors. Example:

======================================================================
ERROR: testFakedbapi (portage.tests.dbapi.test_fakedbapi.TestFakedbapi)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/portage/pym/portage/tests/__init__.py", line 222, in run
    testMethod()
  File "/tmp/portage/pym/portage/tests/dbapi/test_fakedbapi.py", line 62, in testFakedbapi
    env=env, eprefix=tempdir))
  File "/tmp/portage/pym/portage/package/ebuild/config.py", line 529, in __init__
    self.repositories = load_repository_config(self)
  File "/tmp/portage/pym/portage/repository/config.py", line 978, in load_repository_config
    return RepoConfigLoader(repoconfigpaths, settings)
  File "/tmp/portage/pym/portage/repository/config.py", line 619, in __init__
    self._parse(paths, prepos, settings.local_config, default_opts)
  File "/tmp/portage/pym/portage/repository/config.py", line 558, in _parse
    parser = SafeConfigParser(defaults=default_opts)
  File "/usr/lib64/python3.7/configparser.py", line 638, in __init__
    self._read_defaults(defaults)
  File "/usr/lib64/python3.7/configparser.py", line 1210, in _read_defaults
    self.read_dict({self.default_section: defaults})
  File "/usr/lib64/python3.7/configparser.py", line 753, in read_dict
    self.set(section, key, value)
  File "/usr/lib64/python3.7/configparser.py", line 1197, in set
    self._validate_value_types(option=option, value=value)
  File "/usr/lib64/python3.7/configparser.py", line 1182, in _validate_value_types
    raise TypeError("option values must be strings")
TypeError: option values must be strings

======================================================================


This is caused by:
  default_opts['sync-rsync-extra-opts'] = None

[Comment 1 Arfrever Frehtes Taifersar Arahesis 2017-08-28 06:10:33 UTC]

Created attachment 490950 [details, diff]
portage.patch

[Comment 2 Zac Medico 2017-08-28 06:21:36 UTC]

Thanks, applied:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=9750e66503012fe7ca29b4a5c6447aae8b6c539c

[Comment 3 Zac Medico 2017-09-19 21:05:56 UTC]

Released in portage-2.3.9.